[12.x backport] module: remove experimental modules warning#35749
Closed
guybedford wants to merge 1 commit intonodejs:v12.x-stagingfrom
Closed
[12.x backport] module: remove experimental modules warning#35749guybedford wants to merge 1 commit intonodejs:v12.x-stagingfrom
guybedford wants to merge 1 commit intonodejs:v12.x-stagingfrom
Conversation
PR-URL: nodejs#31974 Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Jan Krems <jan.krems@gmail.com> Reviewed-By: Geoffrey Booth <webmaster@geoffreybooth.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
nodejs-github-bot
added
process
targos
approved these changes
Oct 22, 2020
aduh95
approved these changes
Oct 22, 2020
This was referenced Oct 22, 2020
Contributor
Author
|
Superseded by #35757. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This backports the PR with the removal of the experimental warning from #31974.
This seems important as many users are unaware the 12.x implementation provides the same stable base-level modules functionality.
It would be nice to get the approvals here in the mean time, but this should probably only land once the two previously left out backports from the last 12 release have landed:
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes