fs: remove unused assignment

[Trott]

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• commit message follows commit guidelines

[Trott]

@iansu @bcoe @cjihrig This can totally wait until after the push to get everything set up for 15.0 and so on--I know there's a lot going on right now--but I was wondering about taking this trivial change a little further and removing the options validation entirely in cases like this when options.recursive is not set and the validated options object is not subsequently used. I might rename validateRmdirOptions() to validateRecursiveRmdirOptions() to make it clear that the only options validated are ones used with the recursive setting (recursive, maxRetries, and retryDelay) and skip it here and in other places where the validated options aren't used.

Another alternative is to keep the validation but warn the user when those other two options are set and recursive is not.

Mentioning that in case I'm missing/forgetting something that makes that A Bad Idea.

[iansu]

@Trott I think warning when setting either maxRetries or retryDelay without recursive sounds like a good idea. That seems preferable to skipping validation entirely when recursive is not set.

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/33666/

[Trott]

Landed in 7f25fe8