Closed
Conversation
It is already installed in the GitHub runners.
The other way is deprecated.
nodejs-github-bot
added
the
meta
richardlau
approved these changes
Oct 14, 2020
Trott
approved these changes
Oct 14, 2020
lpinca
approved these changes
Oct 14, 2020
jasnell
approved these changes
Oct 14, 2020
4 tasks
Member
Author
|
Can we fast track? |
targos
added
fast-track
github-actions
bot
added
commit-queue-failed
Contributor
Commit Queue failed- Loading data for nodejs/node/pull/35638 ✔ Done loading data for nodejs/node/pull/35638 ----------------------------------- PR info ------------------------------------ Title build: update github workflows (#35638) Author Michaël Zasso (@targos) Branch targos:update-workflows -> nodejs:master Labels fast-track, meta Commits 2 - build: do not install jq in workflows - build: use GITHUB_ENV file to set env variables Committers 1 - Michaël Zasso PR-URL: https://github.com/nodejs/node/pull/35638 Reviewed-By: Richard Lau Reviewed-By: Rich Trott Reviewed-By: Luigi Pinca Reviewed-By: James M Snell ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/35638 Reviewed-By: Richard Lau Reviewed-By: Rich Trott Reviewed-By: Luigi Pinca Reviewed-By: James M Snell -------------------------------------------------------------------------------- ✔ Last GitHub Actions successful ✖ No Jenkins CI runs detected ℹ This PR was created on Wed, 14 Oct 2020 09:19:49 GMT ✔ Approvals: 4 ✔ - Richard Lau (@richardlau): https://github.com/nodejs/node/pull/35638#pullrequestreview-508157108 ✔ - Rich Trott (@Trott) (TSC): https://github.com/nodejs/node/pull/35638#pullrequestreview-508295221 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/35638#pullrequestreview-508666176 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/35638#pullrequestreview-508802687 ℹ This PR is being fast-tracked -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncu Commit Queue action: https://github.com/nodejs/node/actions/runs/310055827 |
targos
added a commit
that referenced
this pull request
Oct 16, 2020
It is already installed in the GitHub runners. PR-URL: #35638 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
targos
added a commit
that referenced
this pull request
Oct 16, 2020
The other way is deprecated. PR-URL: #35638 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Member
Author
|
Landed in c143266...cfbbeea |
BethGriggs
pushed a commit
that referenced
this pull request
Dec 8, 2020
It is already installed in the GitHub runners. PR-URL: #35638 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
BethGriggs
pushed a commit
that referenced
this pull request
Dec 8, 2020
The other way is deprecated. PR-URL: #35638 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
targos
removed
the
commit-queue-failed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See https://github.com/nodejs/node/actions/runs/306130006 for an example with the
set-envdeprecation message.commit 8a7ee81
commit b3e6972