Skip to content

src: minor error cleanups#35493

Merged
Trott merged 2 commits intonodejs:masterfrom
jasnell:src-error-cleanups
Oct 6, 2020
Merged

src: minor error cleanups#35493
Trott merged 2 commits intonodejs:masterfrom
jasnell:src-error-cleanups

Conversation

@jasnell
Copy link
Member

@jasnell jasnell commented Oct 4, 2020

Just a couple of minor idiomatic error cleanups in src

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Oct 4, 2020

Review requested:

  • @nodejs/wasi

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. net Issues and PRs related to the net subsystem. wasi Issues and PRs related to the WebAssembly System Interface. labels Oct 4, 2020
@jasnell jasnell added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 4, 2020
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 4, 2020
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Oct 4, 2020

CI: https://ci.nodejs.org/job/node-test-pull-request/33362/

@addaleax addaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 4, 2020
jasnell added 2 commits October 6, 2020 04:38
@jasnell @Trott
src: use env->ThrowUVException in pipe_wrap
530acd1 
Signed-off-by: James M Snell <jasnell@gmail.com>

PR-URL: nodejs#35493
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@jasnell @Trott
src: more idiomatic error pattern in node_wasi
8beef5e 
Signed-off-by: James M Snell <jasnell@gmail.com>

PR-URL: nodejs#35493
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@Trott Trott force-pushed the src-error-cleanups branch from b465e03 to 8beef5e Compare October 6, 2020 11:39
@Trott Trott merged commit 8beef5e into nodejs:master Oct 6, 2020
@Trott
Copy link
Member

Trott commented Oct 6, 2020 •
edited
Loading

Landed in 78e5875...8beef5e

@danielleadams danielleadams mentioned this pull request Oct 6, 2020
Merged
danielleadams pushed a commit that referenced this pull request Oct 6, 2020
@jasnell @danielleadams
src: use env->ThrowUVException in pipe_wrap
392c881 
Signed-off-by: James M Snell <jasnell@gmail.com>

PR-URL: #35493
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
danielleadams pushed a commit that referenced this pull request Oct 6, 2020
@jasnell @danielleadams
src: more idiomatic error pattern in node_wasi
3f62f99 
Signed-off-by: James M Snell <jasnell@gmail.com>

PR-URL: #35493
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
MylesBorins pushed a commit that referenced this pull request Nov 3, 2020
@jasnell @MylesBorins
src: use env->ThrowUVException in pipe_wrap
7873104 
Signed-off-by: James M Snell <jasnell@gmail.com>

PR-URL: #35493
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
MylesBorins pushed a commit that referenced this pull request Nov 3, 2020
@jasnell @MylesBorins
src: more idiomatic error pattern in node_wasi
ca66837 
Signed-off-by: James M Snell <jasnell@gmail.com>

PR-URL: #35493
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Nov 3, 2020
Merged
MylesBorins pushed a commit that referenced this pull request Nov 16, 2020
@jasnell @MylesBorins
src: use env->ThrowUVException in pipe_wrap
ade27b7 
Signed-off-by: James M Snell <jasnell@gmail.com>

PR-URL: #35493
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
MylesBorins pushed a commit that referenced this pull request Nov 16, 2020
@jasnell @MylesBorins
src: more idiomatic error pattern in node_wasi
7f8834f 
Signed-off-by: James M Snell <jasnell@gmail.com>

PR-URL: #35493
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
joesepi pushed a commit to joesepi/node that referenced this pull request Jan 8, 2021
@jasnell @joesepi
src: use env->ThrowUVException in pipe_wrap
fbf5b39 
Signed-off-by: James M Snell <jasnell@gmail.com>

PR-URL: nodejs#35493
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
joesepi pushed a commit to joesepi/node that referenced this pull request Jan 8, 2021
@jasnell @joesepi
src: more idiomatic error pattern in node_wasi
94b2530 
Signed-off-by: James M Snell <jasnell@gmail.com>

PR-URL: nodejs#35493
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Trott Trott Trott approved these changes

@addaleax addaleax addaleax approved these changes

@watilde watilde watilde approved these changes

@tniessen tniessen tniessen approved these changes

+2 more reviewers

@devnexen devnexen devnexen approved these changes

@crypt096 crypt096 crypt096 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. net Issues and PRs related to the net subsystem. wasi Issues and PRs related to the WebAssembly System Interface.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@jasnell @nodejs-github-bot @Trott @addaleax @watilde @tniessen @devnexen @crypt096