Closed
Conversation
nodejs-github-bot
added
deprecations
Member
aduh95
commented
Oct 2, 2020
Member
|
The DEP0098 thing is a bit more complicated, but it was added to 9.x in a4c28d77f73 after having been (accidentally, I think) removed in bae5de1, prior to which it was added in 7f5334e. Backport PR for it being added to 9.x is #18892. By the way, I'm finding these by doing |
aduh95
commented
Oct 4, 2020
Contributor
Author
Oh that's a neat idea. I was simply searching through the CHANGELOG files, which is clearly not as reliable. I've removed the changes related to DEP0098, PTAL. |
Trott
approved these changes
Oct 4, 2020
aduh95
force-pushed
the
fix-deprecation-history
branch
from
d66f299 to
88a8087
Compare
Contributor
Author
|
I've included two more fixes, PTAL:
|
aduh95
added
the
commit-queue
github-actions
bot
added
commit-queue-failed
Contributor
Commit Queue failed- Loading data for nodejs/node/pull/35455 ✔ Done loading data for nodejs/node/pull/35455 ----------------------------------- PR info ------------------------------------ Title doc: fix deprecation history (#35455) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch aduh95:fix-deprecation-history -> nodejs:master Labels commit-queue, deprecations, doc Commits 1 - doc: fix deprecation history Committers 1 - Antoine du Hamel PR-URL: https://github.com/nodejs/node/pull/35455 Reviewed-By: Rich Trott ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/35455 Reviewed-By: Rich Trott -------------------------------------------------------------------------------- ✔ Last GitHub Actions successful ℹ Doc-only changes ℹ This PR was created on Thu, 01 Oct 2020 22:46:31 GMT ✔ Approvals: 1 ✔ - Rich Trott (@Trott) (TSC): https://github.com/nodejs/node/pull/35455#pullrequestreview-503530131 ✖ This PR needs to wait 30 more hours to land (or 0 hours if there is one more approval) -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncu |
aduh95
added
commit-queue
github-actions
bot
removed
the
commit-queue
Contributor
|
Landed in ef1af47 |
nodejs-github-bot
pushed a commit
that referenced
this pull request
Oct 8, 2020
PR-URL: #35455 Reviewed-By: Rich Trott <rtrott@gmail.com>
BethGriggs
pushed a commit
that referenced
this pull request
Oct 13, 2020
PR-URL: #35455 Reviewed-By: Rich Trott <rtrott@gmail.com>
Merged
joesepi
pushed a commit
to joesepi/node
that referenced
this pull request
Jan 8, 2021
PR-URL: nodejs#35455 Reviewed-By: Rich Trott <rtrott@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DEP0098(efb3259) doesn't appear anywhere in the v9.x nor v8.x changelogs, I don't think it's ever been backported.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes