Closed
Conversation
nodejs-github-bot
added
doc
Collaborator
|
Review requested:
|
Member
Author
|
Marked as draft as I think we need to change the format of the table, and wanted to get some feedback on this approach. |
Member
Author
|
@nodejs/n-api |
4 tasks
mhdawson
commented
Sep 25, 2020
Member
Author
|
Talked it over with in the N-API team meeting today, seems like people were ok with the approach, removing out of draft. |
Member
Author
|
This should probably land https://github.com/nodejs/node/pull/35319/files and then I can rebase this PR on top of it. |
legendecas
approved these changes
Sep 26, 2020
lpinca
approved these changes
Sep 26, 2020
Member
Author
|
See that #35319 has landed, will rebase tomorrow |
Member
Author
|
Rebased, will wait for checks to complete and then land. |
github-actions
bot
removed
the
request-ci
Collaborator
aduh95
reviewed
Oct 5, 2020
aduh95
approved these changes
Oct 8, 2020
Contributor
|
N-API 7 has since been released in v12.19.0. |
Member
Author
|
Updated to include N-API 7 beeing released in v12.19.0. |
- refactor the n-api matrix and add v7 Signed-off-by: Michael Dawson <mdawson@devrus.com>
mhdawson
force-pushed
the
napi-matrix-refactor
branch
from
5f89cc2 to
8d97f90
Compare
mhdawson
added a commit
that referenced
this pull request
Oct 9, 2020
- refactor the n-api matrix and add v7 Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: #35345 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Member
Author
|
Landed in ccfa661 |
Member
BethGriggs
pushed a commit
that referenced
this pull request
Oct 14, 2020
- refactor the n-api matrix and add v7 Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: #35345 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Merged
joesepi
pushed a commit
to joesepi/node
that referenced
this pull request
Jan 8, 2021
- refactor the n-api matrix and add v7 Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: nodejs#35345 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Michael Dawson mdawson@devrus.com
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes