test: fix missing unistd.h on windows

[john-yan]

PL-URL: #3531

[Fishrock123]

cc @bnoordhuis probably

[john-yan]

@bnoordhuis Would you please also land it on v4.x? Thanks.

[bnoordhuis]

This won't work on OS X due to lack of library support. Can I suggest something like this?

#ifdef _WIN32
  Sleep(1000);
#else
  sleep(1);
#endif

[john-yan]

I am happy to use that.

[john-yan]

But since the latest v8 is also using c++11, I think OS X might be able to get around c++11 problems by using new compilers and libraries.

[bnoordhuis]

There are two aspects to C++11 support: compiler support (okay on OS X) and libc++ support (which is lacking.)

[john-yan]

I noticed the default libc++ library on OS X is outdated and doesn't support c++11. I wonder how OS X user compile the latest v8, which is part of nodejs and using c++11? they should have a solution to that. (I think they download the lib from somewhere)

[bnoordhuis]

That's right, it ships with its own copy of libc++: https://chromium.googlesource.com/chromium/buildtools/+/master/third_party/libc++/

[bnoordhuis]

LGTM. CI: https://ci.nodejs.org/job/node-test-pull-request/638/

[bnoordhuis]

Thanks, landed in 4139f2a.

[john-yan]

hello @jasnell , would you please help land it on v4.x? thanks.

[jasnell]

Landed in v4.x-staging in 2fc13e5