zlib: replace usage of internal stream state with public api#34884
Closed
lundibundi wants to merge 1 commit intonodejs:masterfrom
Closed
zlib: replace usage of internal stream state with public api#34884lundibundi wants to merge 1 commit intonodejs:masterfrom
lundibundi wants to merge 1 commit intonodejs:masterfrom
Conversation
lundibundi
commented
Aug 23, 2020
| } | ||
|
|
||
| if (ws.ended) { | ||
| if (this.writableFinished) { |
Member
Author
There was a problem hiding this comment.
IIUC this is slightly off since the .finished will only be set on nextTick but I guess that's okay?
/cc @ronag
github-actions
bot
removed
the
request-ci
Collaborator
mcollina
approved these changes
Aug 23, 2020
Member
mcollina
left a comment
mcollina
left a comment
There was a problem hiding this comment.
lgtm.. I would ask for a citgm run.
Member
Author
Member
|
The docs are rather unclear when exactly callback should be invoked and what that means... |
This comment has been minimized.
This comment has been minimized.
Collaborator
BridgeAR
approved these changes
Aug 23, 2020
10 tasks
jasnell
approved these changes
Aug 24, 2020
This was referenced Aug 25, 2020
addaleax
approved these changes
Aug 26, 2020
Member
Author
|
Can someone interpret the CITGM run for me, please? Are the failures expected from other changes and this is safe to land or is it the fault of this PR since by the looks of it every more or less recent CITGM run failed. |
10 tasks
Member
|
good to go for me |
lundibundi
added
author ready
github-actions
bot
removed
the
commit-queue
Contributor
|
Landed in 7fca0df |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs: #445
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes/cc @nodejs/streams