doc: adopt Microsoft Style Guide officially#34821
doc: adopt Microsoft Style Guide officially#34821Trott wants to merge 0 commit intonodejs:masterfrom
Conversation
|
@nodejs/documentation |
DerekNonGeneric
left a comment
DerekNonGeneric
left a comment
There was a problem hiding this comment.
You know my preferences on these style guides, but I have no objection.
doc/guides/doc-style-guide.md
Outdated
There was a problem hiding this comment.
I mentioned this to @addaleax and I don't know of a more appropriate situation to bring it up other than right here, but I wish we could use scoped packages for these: @nodejs/remark-preset-lint-node.
There was a problem hiding this comment.
@nodejs-core/* maybe, so we differentiate between external packages and packages targeting collaborators?
There was a problem hiding this comment.
[…] differentiate between external packages and packages targeting collaborators
Yes, exactly.
There was a problem hiding this comment.
@mmarchini, sorry, not targeting, but rather collaborating on. Why can't we use @nodejs?
There was a problem hiding this comment.
IIRC it was originally reserved on npm so we could use it for new modules/standard library to go under this scope (nodejs/TSC#389 for some of the discussions around this). IMO if we end up using it for that purpose, mixing with tooling that is used exclusively on Node.js core will be confusing, so scoping to something specific for the internal workflow of the project makes more sense.
There was a problem hiding this comment.
We have plans for another package-scoped bare specifier: @nodejs/resolver-conformance-tests.
Refs: https://github.com/nodejs/modules/issues/472#issuecomment-584994986
doc/guides/doc-style-guide.md
Outdated
There was a problem hiding this comment.
Add a link to The Chicago Manual of Style?
There was a problem hiding this comment.
I think I"m going to remove the Chicago Manual of Style. It can always be added in a later PR. I'm kind of torn about it. On the one hand, it is pretty much the standard for this sort of stuff. On the other hand, it is not freely available online. Links would be to partial versions, or cheatsheets, or a site where you could buy it.
There was a problem hiding this comment.
(And we can always add it later.)
PR-URL: #34821 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Ricky Zhou <0x19951125@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is>
|
Landed in bc8a4df |
PR-URL: #34821 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Ricky Zhou <0x19951125@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is>
PR-URL: #34821 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Ricky Zhou <0x19951125@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is>
PR-URL: #34821 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Ricky Zhou <0x19951125@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is>
8 participants
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes