Skip to content

test: skip node-api/test_worker_terminate_finalization#34732

Closed
addaleax wants to merge 1 commit intonodejs:masterfrom
addaleax:no-test_worker_terminate_finalization
Closed

test: skip node-api/test_worker_terminate_finalization#34732
addaleax wants to merge 1 commit intonodejs:masterfrom
addaleax:no-test_worker_terminate_finalization

Conversation

@addaleax
Copy link
Member

@addaleax addaleax commented Aug 11, 2020

The test fails under ASAN/valgrind. Since it has not been working
properly until today anyway, skip it.

Refs: #34731

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@addaleax
test: skip node-api/test_worker_terminate_finalization
1078495 
The test fails under ASAN/valgrind. Since it has not been working
properly until today anyway, skip it.

Refs: nodejs#34731
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Aug 11, 2020
@addaleax
Copy link
Member Author

addaleax commented Aug 11, 2020

👍 to fast-track to unbreak test-asan?

@addaleax addaleax added fast-track PRs that do not need to wait for 48 hours to land. node-api Issues and PRs related to the Node-API. request-ci Add this label to start a Jenkins CI on a PR. labels Aug 11, 2020
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 11, 2020
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Aug 11, 2020 •
edited by addaleax
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/32735/ (:green_heart:)

mmarchini pushed a commit that referenced this pull request Aug 12, 2020
@addaleax @mmarchini
test: skip node-api/test_worker_terminate_finalization
cf5d7c0 
The test fails under ASAN/valgrind. Since it has not been working
properly until today anyway, skip it.

Refs: #34731

PR-URL: #34732
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matheus Marchini <mat@mmarchini.me>
@mmarchini
Copy link
Contributor

mmarchini commented Aug 12, 2020

Landed in cf5d7c0

@mmarchini mmarchini closed this Aug 12, 2020
MylesBorins pushed a commit that referenced this pull request Aug 17, 2020
@addaleax @MylesBorins
test: skip node-api/test_worker_terminate_finalization
e5a3991 
The test fails under ASAN/valgrind. Since it has not been working
properly until today anyway, skip it.

Refs: #34731

PR-URL: #34732
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matheus Marchini <mat@mmarchini.me>
@danielleadams danielleadams mentioned this pull request Aug 20, 2020
Merged
BethGriggs pushed a commit that referenced this pull request Aug 20, 2020
@addaleax @BethGriggs
test: skip node-api/test_worker_terminate_finalization
0472d16 
The test fails under ASAN/valgrind. Since it has not been working
properly until today anyway, skip it.

Refs: #34731

PR-URL: #34732
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matheus Marchini <mat@mmarchini.me>
addaleax added a commit that referenced this pull request Sep 22, 2020
@addaleax
test: skip node-api/test_worker_terminate_finalization
3b70c10 
The test fails under ASAN/valgrind. Since it has not been working
properly until today anyway, skip it.

Refs: #34731

PR-URL: #34732
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matheus Marchini <mat@mmarchini.me>
addaleax added a commit that referenced this pull request Sep 22, 2020
@addaleax
test: skip node-api/test_worker_terminate_finalization
335b61a 
The test fails under ASAN/valgrind. Since it has not been working
properly until today anyway, skip it.

Refs: #34731

PR-URL: #34732
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matheus Marchini <mat@mmarchini.me>
@codebytere codebytere mentioned this pull request Sep 28, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes

+1 more reviewer

@mmarchini mmarchini mmarchini approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

fast-track PRs that do not need to wait for 48 hours to land. node-api Issues and PRs related to the Node-API. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@addaleax @nodejs-github-bot @mmarchini @jasnell