doc: use sentence-casing for headers in collaborator guide#34713
Merged
Trott merged 0 commit intonodejs:masterfrom Aug 12, 2020
Merged
doc: use sentence-casing for headers in collaborator guide#34713Trott merged 0 commit intonodejs:masterfrom
Trott merged 0 commit intonodejs:masterfrom
Conversation
targos
approved these changes
Aug 10, 2020
jasnell
approved these changes
Aug 10, 2020
jvmazagao
approved these changes
Aug 10, 2020
mmarchini
approved these changes
Aug 10, 2020
Contributor
mmarchini
left a comment
mmarchini
left a comment
There was a problem hiding this comment.
LGTM, although maybe some specific terms would benefit from headline case (Breaking Changes, Pull Requests, Long Term Support). Not particularly invested either way, so I'm fine with this landing as is too 🤷🏻♀️
lpinca
approved these changes
Aug 10, 2020
iSkore
approved these changes
Aug 10, 2020
Member
Author
|
Landed in f948359 |
MylesBorins
pushed a commit
that referenced
this pull request
Aug 17, 2020
The collaborator guide uses both sentence case and headline case for headings. Use sentence case to conform with our style guide. PR-URL: #34713 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Mary Marchini <oss@mmarchini.me> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
BethGriggs
pushed a commit
that referenced
this pull request
Aug 20, 2020
The collaborator guide uses both sentence case and headline case for headings. Use sentence case to conform with our style guide. PR-URL: #34713 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Mary Marchini <oss@mmarchini.me> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
addaleax
pushed a commit
that referenced
this pull request
Sep 22, 2020
The collaborator guide uses both sentence case and headline case for headings. Use sentence case to conform with our style guide. PR-URL: #34713 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Mary Marchini <oss@mmarchini.me> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
addaleax
pushed a commit
that referenced
this pull request
Sep 22, 2020
The collaborator guide uses both sentence case and headline case for headings. Use sentence case to conform with our style guide. PR-URL: #34713 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Mary Marchini <oss@mmarchini.me> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The collaborator guide uses both sentence case and headline case for
headings. Use sentence case to conform with our style guide.
Checklist