test: use process.env.PYTHON to spawn python#34700
Closed
addaleax wants to merge 1 commit intonodejs:masterfrom
Closed
test: use process.env.PYTHON to spawn python#34700addaleax wants to merge 1 commit intonodejs:masterfrom
addaleax wants to merge 1 commit intonodejs:masterfrom
Conversation
Co-authored-by: Jérémy Lal <kapouer@melix.org> Fixes: nodejs#34699
richardlau
approved these changes
Aug 9, 2020
github-actions
bot
removed
the
request-ci
Collaborator
This was referenced Aug 10, 2020
lpinca
approved these changes
Aug 10, 2020
gengjiawen
approved these changes
Aug 10, 2020
Member
gengjiawen
left a comment
gengjiawen
left a comment
There was a problem hiding this comment.
Any thought export this in common ?
addaleax
added
the
author ready
Collaborator
Member
Author
I don’t have a strong opinion on that. |
jasnell
approved these changes
Aug 10, 2020
This was referenced Aug 11, 2020
Nelias
approved these changes
Aug 13, 2020
This was referenced Aug 14, 2020
rickyes
approved these changes
Aug 14, 2020
rickyes
pushed a commit
that referenced
this pull request
Aug 14, 2020
Co-authored-by: Jérémy Lal <kapouer@melix.org> Fixes: #34699 PR-URL: #34700 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ricky Zhou <0x19951125@gmail.com>
Contributor
|
Landed in 888eb5a |
6 tasks
MylesBorins
pushed a commit
that referenced
this pull request
Aug 17, 2020
Co-authored-by: Jérémy Lal <kapouer@melix.org> Fixes: #34699 PR-URL: #34700 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ricky Zhou <0x19951125@gmail.com>
Merged
BethGriggs
pushed a commit
that referenced
this pull request
Aug 20, 2020
Co-authored-by: Jérémy Lal <kapouer@melix.org> Fixes: #34699 PR-URL: #34700 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ricky Zhou <0x19951125@gmail.com>
addaleax
added a commit
that referenced
this pull request
Sep 22, 2020
Co-authored-by: Jérémy Lal <kapouer@melix.org> Fixes: #34699 PR-URL: #34700 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ricky Zhou <0x19951125@gmail.com>
addaleax
added a commit
that referenced
this pull request
Sep 22, 2020
Co-authored-by: Jérémy Lal <kapouer@melix.org> Fixes: #34699 PR-URL: #34700 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ricky Zhou <0x19951125@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #34699
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes