Skip to content

doc: add author-ready label ref to onboarding-extras guide#34381

Closed
ruyadorno wants to merge 1 commit intonodejs:masterfrom
ruyadorno:add-author-ready-ref-to-onboarding-extras-doc
Closed

doc: add author-ready label ref to onboarding-extras guide#34381
ruyadorno wants to merge 1 commit intonodejs:masterfrom
ruyadorno:add-author-ready-ref-to-onboarding-extras-doc

Conversation

@ruyadorno
Copy link
Member

@ruyadorno ruyadorno commented Jul 15, 2020

The "Labels" section of doc/guides/onboarding-extras.md was missing a reference to the author-ready label. This commit adds a description similar to the definition found in doc/guides/collaborator-guide.md with the goal of making it easier for new contributors to find labels info all in one place.

Just a small improvement suggested during the onboarding session 😊

/cc @addaleax

Checklist
  • make lint passes
  • documentation is changed or added
  • commit message follows commit guidelines

@ruyadorno ruyadorno added the doc Issues and PRs related to the documentations. label Jul 15, 2020
richardlau
richardlau approved these changes Jul 15, 2020
View reviewed changes
Copy link
Member

@richardlau richardlau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The list of labels is almost in alphabetical order. If it was I'd ask for this to be moved to the top of the General section but since the list isn't already sorted ¯\_(ツ)_/¯.

@ruyadorno
Copy link
Member Author

ruyadorno commented Jul 15, 2020

@richardlau agreed! I believe the semver-* section comes after the initial list since it has a larger description with subitems, I tried to follow that same pattern there 😁

@ruyadorno ruyadorno added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jul 15, 2020
@richardlau
Copy link
Member

richardlau commented Jul 15, 2020

I'm going to remove the author ready label as the GitHub actions workflows (i.e. the CI for docs changes) haven't started yet, probably due to the current incident: https://www.githubstatus.com/incidents/phnch1rww464

@richardlau richardlau removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jul 15, 2020
@ruyadorno ruyadorno force-pushed the add-author-ready-ref-to-onboarding-extras-doc branch from 6e9043e to 780dfbf Compare July 15, 2020 19:31
@ruyadorno
Copy link
Member Author

ruyadorno commented Jul 15, 2020

ok @richardlau I amended the commit in order to kickoff CI again (lmk if there's an easier way to do that) 😊 it looks like that incident has been resolved.

can you please re-approve just in case?

@richardlau richardlau added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jul 15, 2020
jasnell
jasnell reviewed Jul 17, 2020
View reviewed changes
jasnell
jasnell reviewed Jul 17, 2020
View reviewed changes
@ruyadorno ruyadorno force-pushed the add-author-ready-ref-to-onboarding-extras-doc branch 2 times, most recently from 8684436 to 8141ab0 Compare July 21, 2020 18:19
@ruyadorno
doc: add author-ready label ref to onboarding doc
5c00e88 
The "Labels" section of doc/guides/onboarding-extras.md was missing a
reference to the `author-ready` label. This commit adds a description
similar to the definition found in doc/guides/collaborator-guide.md
with the goal of making it easier for new contributors to find labels
info all in one place.
@ruyadorno ruyadorno force-pushed the add-author-ready-ref-to-onboarding-extras-doc branch from 8141ab0 to 5c00e88 Compare July 21, 2020 18:20
@ruyadorno ruyadorno added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. and removed author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Jul 21, 2020
MylesBorins
MylesBorins approved these changes Jul 22, 2020
View reviewed changes
Copy link
Contributor

@MylesBorins MylesBorins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

MylesBorins pushed a commit that referenced this pull request Jul 22, 2020
@ruyadorno @MylesBorins
doc: add author-ready label ref to onboarding doc
bfef588 
The "Labels" section of doc/guides/onboarding-extras.md was missing a
reference to the `author-ready` label. This commit adds a description
similar to the definition found in doc/guides/collaborator-guide.md
with the goal of making it easier for new contributors to find labels
info all in one place.

PR-URL: #34381
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
@MylesBorins
Copy link
Contributor

MylesBorins commented Jul 22, 2020

only failure was unrelated CI (for a job we are looking at removing)

Landed in bfef588

cjihrig pushed a commit that referenced this pull request Jul 23, 2020
@ruyadorno @cjihrig
doc: add author-ready label ref to onboarding doc
6f87fea 
The "Labels" section of doc/guides/onboarding-extras.md was missing a
reference to the `author-ready` label. This commit adds a description
similar to the definition found in doc/guides/collaborator-guide.md
with the goal of making it easier for new contributors to find labels
info all in one place.

PR-URL: #34381
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jul 27, 2020
@ruyadorno @MylesBorins
doc: add author-ready label ref to onboarding doc
7d058a4 
The "Labels" section of doc/guides/onboarding-extras.md was missing a
reference to the `author-ready` label. This commit adds a description
similar to the definition found in doc/guides/collaborator-guide.md
with the goal of making it easier for new contributors to find labels
info all in one place.

PR-URL: #34381
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
@ruyadorno ruyadorno mentioned this pull request Jul 28, 2020
Merged
addaleax pushed a commit that referenced this pull request Sep 22, 2020
@ruyadorno @addaleax
doc: add author-ready label ref to onboarding doc
a8abef3 
The "Labels" section of doc/guides/onboarding-extras.md was missing a
reference to the `author-ready` label. This commit adds a description
similar to the definition found in doc/guides/collaborator-guide.md
with the goal of making it easier for new contributors to find labels
info all in one place.

PR-URL: #34381
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
addaleax pushed a commit that referenced this pull request Sep 22, 2020
@ruyadorno @addaleax
doc: add author-ready label ref to onboarding doc
c91e31d 
The "Labels" section of doc/guides/onboarding-extras.md was missing a
reference to the `author-ready` label. This commit adds a description
similar to the definition found in doc/guides/collaborator-guide.md
with the goal of making it easier for new contributors to find labels
info all in one place.

PR-URL: #34381
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
@codebytere codebytere mentioned this pull request Sep 28, 2020
Merged
@mhdawson mhdawson mentioned this pull request Jan 18, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell left review comments

@addaleax addaleax addaleax approved these changes

@richardlau richardlau richardlau approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@trivikr trivikr trivikr approved these changes

@juanarbol juanarbol juanarbol approved these changes

@Flarna Flarna Flarna approved these changes

+1 more reviewer

@MylesBorins MylesBorins MylesBorins approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@ruyadorno @richardlau @MylesBorins @jasnell @addaleax @gireeshpunathil @trivikr @juanarbol @Flarna