doc: sync deprecation numbers with v14.x#34368
Closed
BethGriggs wants to merge 2 commits intonodejs:masterfrom
Closed
doc: sync deprecation numbers with v14.x#34368BethGriggs wants to merge 2 commits intonodejs:masterfrom
BethGriggs wants to merge 2 commits intonodejs:masterfrom
Conversation
Syncs master and v14.x for DEP0143 - `Transform._transformState`. Bumps `module.parent` from DEP0143 to DEP0144 on master. Adds missing DEP number and metadata for DEP0145: `socket.bufferSize`.
nodejs-github-bot
added
deprecations
addaleax
approved these changes
Jul 14, 2020
richardlau
approved these changes
Jul 14, 2020
Member
Author
|
I think I may need to also patch #32217 to account for the new DEP number. Should that be in a second commit of this PR or the same commit? |
Contributor
|
@BethGriggs I've already patched the backport PR for #32217 so it should be good |
BethGriggs
force-pushed
the
sync-deprecations
branch
from
b3562a4 to
eeda609
Compare
Member
Author
|
I've added eeda609 which updates the DEP number for the pending deprecation warning and test for |
Contributor
|
fast track? |
MylesBorins
added
the
fast-track
Collaborator
Member
|
The other option would be to move |
Contributor
|
@sxa I'm going to go ahead and land this and make sure 14.6.0 is in sync so we can just move forward :D |
Contributor
|
Landed in 3b13032...128ed10 |
MylesBorins
pushed a commit
that referenced
this pull request
Jul 15, 2020
Syncs master and v14.x for DEP0143 - `Transform._transformState`. Bumps `module.parent` from DEP0143 to DEP0144 on master. Adds missing DEP number and metadata for DEP0145: `socket.bufferSize`. PR-URL: #34368 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Myles Borins <myles.borins@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Jul 15, 2020
PR-URL: #34368 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Myles Borins <myles.borins@gmail.com>
MylesBorins
added a commit
that referenced
this pull request
Jul 15, 2020
Syncs master and v14.x for DEP0143 - `Transform._transformState`. Bumps `module.parent` from DEP0143 to DEP0144 on master. Adds missing DEP number and metadata for DEP0145: `socket.bufferSize`. PR-URL: #34368 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Myles Borins <myles.borins@gmail.com>
Merged
13 tasks
MylesBorins
added a commit
that referenced
this pull request
Jul 16, 2020
Syncs master and v14.x for DEP0143 - `Transform._transformState`. Bumps `module.parent` from DEP0143 to DEP0144 on master. Adds missing DEP number and metadata for DEP0145: `socket.bufferSize`. PR-URL: #34368 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Myles Borins <myles.borins@gmail.com>
This was referenced Jul 17, 2020
cjihrig
pushed a commit
that referenced
this pull request
Jul 23, 2020
Syncs master and v14.x for DEP0143 - `Transform._transformState`. Bumps `module.parent` from DEP0143 to DEP0144 on master. Adds missing DEP number and metadata for DEP0145: `socket.bufferSize`. PR-URL: #34368 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Myles Borins <myles.borins@gmail.com>
cjihrig
pushed a commit
that referenced
this pull request
Jul 23, 2020
PR-URL: #34368 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Myles Borins <myles.borins@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DEP numbers are out of sync between master and v14.x because DEP0143 -
Transform._transformStatelanded on v14.x first.This PR adds DEP0143 -
Transform._transformStatetodoc/api/deprecations.mdon master. This forces themodule.parentdeprecation to move from DEP0143 to DEP0144. Themodule.parentdeprecation has not been formally released (excluding nightly builds) so updating the DEP number should be low risk.Refs: #33533 (comment)
Syncs master and v14.x for DEP0143 -
Transform._transformState.Bumps
module.parentfrom DEP0143 to DEP0144 on master. Addsmissing DEP number and metadata for DEP0145:
socket.bufferSize.Checklist