build: add benchmark tests to CI runs#34288
Merged
Trott merged 0 commit intonodejs:masterfrom Jul 14, 2020
Merged
Conversation
nodejs-github-bot
added
build
This comment has been minimized.
This comment has been minimized.
This was referenced Jul 12, 2020
This comment has been minimized.
This comment has been minimized.
Member
Author
|
@nodejs/testing |
Collaborator
Member
Author
|
@nodejs/build @nodejs/collaborators This is ready to go, I think, but needs some approvals/reviews. |
addaleax
approved these changes
Jul 13, 2020
mmarchini
approved these changes
Jul 13, 2020
Member
Author
|
Landed in c7627da |
Contributor
|
This is causing test failures when landed on v14.x. Would you be willing to open a backport? |
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Jul 15, 2020
Closes: nodejs#34321 PR-URL: nodejs#34288 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Matheus Marchini <mat@mmarchini.me>
Member
Author
Not sure where the CI results for this on 14.x are, so running this: https://ci.nodejs.org/job/node-test-commit/39653/ Mostly a note to self for later. |
Member
Author
No related test failures, I don't think. (One seemingly-unrelated macOS failure.) @MylesBorins Does this still need a backport or anything? Or can it go in as-is? |
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes