deps: update zlib to upstream 8603eee#34183
Closed
targos wants to merge 2 commits intonodejs:masterfrom
Closed
Conversation
Updated as described in doc/guides/maintaining-zlib.md.
Member
|
FWIW there's #33044 that attempted to rework the zlib.gyp file to more closely follow the structure of the gn file (e.g. targets, defines, etc.) in a similar way to how we handle V8. It reportedly fixes the unofficial 32-bit x86 builds (#33019 (comment)) but I'm close to abandoning it as I don't really have time to investigate the drop in benchmarks. |
addaleax
reviewed
Jul 3, 2020
Fix the compile flags so that zlib can run on CPUs that do not have SSSE3/SSE4.2/etc. Do not compile zlib with flags that indicate that those features are available, and instead enable them selectively for functions that use them. There are probably better way to do this, e.g. through gyp file modifications as suggested in the issue. However, this patch should do just fine until that happens. Fixes: nodejs#32553 PR-URL: nodejs#32627 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com>
Member
Author
|
The build breaks on Windows. It seems to conflict with the zlib internal to V8: |
Member
Author
|
any idea? |
Member
Author
|
Replaced with #41745 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated as described in doc/guides/maintaining-zlib.md.
I need help to fix a compiler error: