meta: fixup CODEOWNERS so it hopefully works#34147
Closed
Conversation
the CODEOWNERS rules for QUIC are not working and it's not entirely clear why. Hoping it's just the way the paths were specified.
jasnell
added
meta
Member
Author
|
Looks like github recognizes the CODEOWNERS rules with this change:
|
addaleax
approved these changes
Jul 1, 2020
gengjiawen
approved these changes
Jul 1, 2020
jasnell
added a commit
that referenced
this pull request
Jul 1, 2020
the CODEOWNERS rules for QUIC are not working and it's not entirely clear why. Hoping it's just the way the paths were specified. PR-URL: #34147 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Member
Author
|
Landed in e20beaf |
Member
|
@jasnell can child teams have higher permissions than their parent team? I'm wondering if we could have the parent team be like |
Member
Author
|
Not sure really. They might? |
Contributor
|
They probably can, but someone mentioned in another PR that we're almost on the limit number of teams we can have on the Org. Also, this setup would make it harder for us to keep things organized (someone move to emeritus, now we need to remove them from |
MylesBorins
pushed a commit
that referenced
this pull request
Jul 14, 2020
the CODEOWNERS rules for QUIC are not working and it's not entirely clear why. Hoping it's just the way the paths were specified. PR-URL: #34147 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Jul 16, 2020
the CODEOWNERS rules for QUIC are not working and it's not entirely clear why. Hoping it's just the way the paths were specified. PR-URL: #34147 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
addaleax
pushed a commit
that referenced
this pull request
Sep 22, 2020
the CODEOWNERS rules for QUIC are not working and it's not entirely clear why. Hoping it's just the way the paths were specified. PR-URL: #34147 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the CODEOWNERS rules for QUIC are not working and it's not entirely clear why.
Hoping it's just the way the paths were specified.
Fast-track?
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes