quic: minor cleanups in quic_buffer#34087
Closed
jasnell wants to merge 2 commits intonodejs:masterfrom
Closed
Conversation
jasnell
added
the
quic
nodejs-github-bot
added
c++
Member
Author
addaleax
approved these changes
Jun 27, 2020
devnexen
approved these changes
Jun 27, 2020
Collaborator
Member
Author
jasnell
added a commit
that referenced
this pull request
Jun 30, 2020
PR-URL: #34087 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: David Carlier <devnexen@gmail.com>
Member
Author
|
Landed in 204f20f |
Contributor
|
Marked as "backport-requested" because I do not believe quic is on 14.x yet. Should we change the label to "dont-land"? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Minor additional cleanup to
QuicBufferChecklist
make -j4 test(UNIX), orvcbuild test(Windows) passes