zlib: remove redundant variable in zlibBufferOnEnd#34072
Closed
puzpuzpuz wants to merge 1 commit intonodejs:masterfrom
Closed
zlib: remove redundant variable in zlibBufferOnEnd#34072puzpuzpuz wants to merge 1 commit intonodejs:masterfrom
puzpuzpuz wants to merge 1 commit intonodejs:masterfrom
Conversation
addaleax
approved these changes
Jun 26, 2020
lpinca
approved these changes
Jun 26, 2020
Collaborator
richardlau
approved these changes
Jun 27, 2020
puzpuzpuz
added a commit
that referenced
this pull request
Jun 29, 2020
PR-URL: #34072 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Member
Author
|
Landed in da8a1ef |
MylesBorins
pushed a commit
that referenced
this pull request
Jul 14, 2020
PR-URL: #34072 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Jul 16, 2020
PR-URL: #34072 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
addaleax
pushed a commit
that referenced
this pull request
Sep 22, 2020
PR-URL: #34072 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes a redundant variable, which is never assigned, from the
zlibBufferOnEndfunction. Most likely it's a leftover from one of recent refactorings.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes