test: AsyncLocalStorage works with thenables#34008
Closed
Flarna wants to merge 1 commit intonodejs:masterfrom
Closed
test: AsyncLocalStorage works with thenables#34008Flarna wants to merge 1 commit intonodejs:masterfrom
Flarna wants to merge 1 commit intonodejs:masterfrom
Conversation
This adds a test to verify that AsyncLocalStorage works with thenables.
nodejs-github-bot
added
async_hooks
targos
approved these changes
Jun 22, 2020
HarshithaKP
reviewed
Jun 22, 2020
jasnell
approved these changes
Jun 22, 2020
Collaborator
Collaborator
Flarna
added
the
author ready
This was referenced Jun 23, 2020
Member
Author
|
Landed in a2b1b92 |
This was referenced Jun 25, 2020
15 tasks
Merged
Merged
Flarna
added a commit
to dynatrace-oss-contrib/node
that referenced
this pull request
Sep 23, 2020
This adds a test to verify that AsyncLocalStorage works with thenables. PR-URL: nodejs#34008 Refs: nodejs#33778 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a test to verify that AsyncLocalStorage works with thenables which works since the v8 fix done in #33778.
The test is based on the samples done by @Qard in https://gist.github.com/Qard/faad53ba2368db54c95828365751d7bc
Refs: #33778
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes