benchmark: fix EventTarget benchmark

[mscdex]

Fixes: #33782

Instead of removing the benchmark completely, I've opted to simply tweak it as little as possible so that it no longer crashes.

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• commit message follows commit guidelines

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/32011/

[mscdex]

On a related note, is there a reason why we aren't running make test-benchmark in CI to prevent issues like this? I thought benchmark tests used to be run along with all of the normal tests?

/cc @nodejs/collaborators

[Trott]

On a related note, is there a reason why we aren't running make test-benchmark in CI to prevent issues like this? I thought benchmark tests used to be run along with all of the normal tests?

/cc @nodejs/collaborators

People complained that they took too long and timed out too much, so we moved them to node-daily-master. I wouldn't be opposed to adding them back to regular CI runs if we can get regular CI to be less unreliable. The current situation is pretty bad.

[BridgeAR]

LGTM

[BridgeAR]

I suggest to run the benchmark tests on our CI but not locally.

[mscdex]

People complained that they took too long and timed out too much, so we moved them to node-daily-master. I wouldn't be opposed to adding them back to regular CI runs if we can get regular CI to be less unreliable. The current situation is pretty bad.

As far as I can tell, the node-daily-master CI job isn't currently failing on the EventTarget benchmark like it should be. Does anyone regularly check/monitor the results of node-daily-master?

[mcollina]

lgtm

[mscdex]

Benchmark CI as a test: https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/621/

[jasnell]

@mscdex ... I pulled this commit into #34015 so that we can land a batch of the eventtarget related items at once. Do you mind if we close this one in favor of that?

[Trott]

As far as I can tell, the node-daily-master CI job isn't currently failing on the EventTarget benchmark like it should be. Does anyone regularly check/monitor the results of node-daily-master?

I check it every day. (Sam Roberts did for a while too, but I think he stopped checking a week or three ago.) However I have not had the time to follow up on the various issues. I just see what's failing, feel a pang of guilt that I don't have time to dig in on it right now, and move on. It's my once-a-day guilt-shot.