src: simplify alignment-handling code#33884
Closed
addaleax wants to merge 2 commits intonodejs:masterfrom
Closed
Conversation
Use a common function to handle alignment computations in multiple places.
nodejs-github-bot
added
c++
jasnell
approved these changes
Jun 15, 2020
Collaborator
danbev
approved these changes
Jun 16, 2020
jasnell
approved these changes
Jun 16, 2020
18 tasks
tniessen
approved these changes
Jun 18, 2020
36 tasks
addaleax
added
the
author ready
Collaborator
addaleax
added a commit
that referenced
this pull request
Jun 19, 2020
Use a common function to handle alignment computations in multiple places. PR-URL: #33884 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Member
Author
|
Landed in 2899588 |
This was referenced Jun 20, 2020
codebytere
pushed a commit
that referenced
this pull request
Jun 27, 2020
Use a common function to handle alignment computations in multiple places. PR-URL: #33884 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Merged
codebytere
pushed a commit
that referenced
this pull request
Jun 30, 2020
Use a common function to handle alignment computations in multiple places. PR-URL: #33884 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use a common function to handle alignment computations in
multiple places.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes