Merged
Conversation
devnexen
approved these changes
Jun 7, 2020
lpinca
approved these changes
Jun 7, 2020
evanlucas
approved these changes
Jun 8, 2020
Collaborator
Collaborator
13 tasks
Collaborator
Collaborator
Collaborator
Update ESLint to 7.2.0 PR-URL: nodejs#33776 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com>
18 tasks
codebytere
pushed a commit
that referenced
this pull request
Jun 18, 2020
Update ESLint to 7.2.0 PR-URL: #33776 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com>
36 tasks
Merged
codebytere
pushed a commit
that referenced
this pull request
Jun 30, 2020
Update ESLint to 7.2.0 PR-URL: #33776 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com>
codebytere
pushed a commit
that referenced
this pull request
Jul 10, 2020
Update ESLint to 7.2.0 PR-URL: #33776 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com>
Merged
codebytere
pushed a commit
that referenced
this pull request
Jul 14, 2020
Update ESLint to 7.2.0 PR-URL: #33776 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update ESLint to 7.2.0
(The
no-unused-varsrule has changed the way it reports errors. This required changing a benchmark and a test.)Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes