doc: add formatting for version numbers to doc-style-guide.md#33755
Closed
Trott wants to merge 0 commit intonodejs:masterfrom
Closed
doc: add formatting for version numbers to doc-style-guide.md#33755Trott wants to merge 0 commit intonodejs:masterfrom
Trott wants to merge 0 commit intonodejs:masterfrom
Conversation
addaleax
approved these changes
Jun 5, 2020
richardlau
approved these changes
Jun 5, 2020
lpinca
approved these changes
Jun 5, 2020
Member
lpinca
left a comment
lpinca
left a comment
There was a problem hiding this comment.
LGTM even though node -v prints v14.4.0.
Member
Author
Yeah, there are a few places where the |
Member
|
@lpinca The docs also use |
Trott
added
the
author ready
trivikr
approved these changes
Jun 7, 2020
Trott
added a commit
that referenced
this pull request
Jun 7, 2020
PR-URL: #33755 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Member
Author
|
Landed in eeede81 |
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Jun 8, 2020
Linting the style guide is failing due to a recent addition in nodejs#33755 landing before the lint library being updated in nodejs#33727. Sorry about the error.
3 tasks
codebytere
pushed a commit
that referenced
this pull request
Jun 18, 2020
PR-URL: #33755 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Merged
codebytere
pushed a commit
that referenced
this pull request
Jun 30, 2020
PR-URL: #33755 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
codebytere
pushed a commit
that referenced
this pull request
Jul 9, 2020
PR-URL: #33755 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Merged
codebytere
pushed a commit
that referenced
this pull request
Jul 14, 2020
PR-URL: #33755 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes