doc: change "pre Node.js v0.10" to "prior to Node.js 0.10"#33754
Closed
Trott wants to merge 0 commit intonodejs:masterfrom
Closed
doc: change "pre Node.js v0.10" to "prior to Node.js 0.10"#33754Trott wants to merge 0 commit intonodejs:masterfrom
Trott wants to merge 0 commit intonodejs:masterfrom
Conversation
nodejs-github-bot
added
crypto
lpinca
approved these changes
Jun 5, 2020
richardlau
approved these changes
Jun 5, 2020
Trott
added
the
author ready
benjamingr
approved these changes
Jun 5, 2020
trivikr
approved these changes
Jun 7, 2020
Trott
added a commit
that referenced
this pull request
Jun 7, 2020
The phrasing "pre Node.js v0.10" is not grammatical, as "pre" is not a word. This also changes "Node.js v0.10" to "Node.js 0.10". We dropped use of the "v" prefix in prose some time ago to avoid confusion as to whether "v8" referred to the V8 JavaScript engine or Node.js 8.x. PR-URL: #33754 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Member
Author
|
Landed in 101e0a9 |
codebytere
pushed a commit
that referenced
this pull request
Jun 18, 2020
The phrasing "pre Node.js v0.10" is not grammatical, as "pre" is not a word. This also changes "Node.js v0.10" to "Node.js 0.10". We dropped use of the "v" prefix in prose some time ago to avoid confusion as to whether "v8" referred to the V8 JavaScript engine or Node.js 8.x. PR-URL: #33754 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Merged
codebytere
pushed a commit
that referenced
this pull request
Jun 30, 2020
The phrasing "pre Node.js v0.10" is not grammatical, as "pre" is not a word. This also changes "Node.js v0.10" to "Node.js 0.10". We dropped use of the "v" prefix in prose some time ago to avoid confusion as to whether "v8" referred to the V8 JavaScript engine or Node.js 8.x. PR-URL: #33754 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
codebytere
pushed a commit
that referenced
this pull request
Jul 9, 2020
The phrasing "pre Node.js v0.10" is not grammatical, as "pre" is not a word. This also changes "Node.js v0.10" to "Node.js 0.10". We dropped use of the "v" prefix in prose some time ago to avoid confusion as to whether "v8" referred to the V8 JavaScript engine or Node.js 8.x. PR-URL: #33754 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Merged
codebytere
pushed a commit
that referenced
this pull request
Jul 14, 2020
The phrasing "pre Node.js v0.10" is not grammatical, as "pre" is not a word. This also changes "Node.js v0.10" to "Node.js 0.10". We dropped use of the "v" prefix in prose some time ago to avoid confusion as to whether "v8" referred to the V8 JavaScript engine or Node.js 8.x. PR-URL: #33754 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The phrasing "pre Node.js v0.10" is not grammatical, as "pre" is not a
word. This also changes "Node.js v0.10" to "Node.js 0.10". We dropped
use of the "v" prefix in prose some time ago to avoid confusion as to
whether "v8" referred to the V8 JavaScript engine or Node.js 8.x.
I checked for internal links to this section in the docs but didn't find any.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes