Conversation
|
I would put that in the same parentheses as the ^C message, otherwise I 👍 this change! |
|
Needs a proper commit message and PR description. Please see https://github.com/nodejs/node/blob/master/CONTRIBUTING.md |
|
-1, I think the current message is sufficient. It makes no sense to input .exit after a CTRL-C, when one can just .exit without the preceding keypress. |
|
@hemanth .. the branch name is inconsequential. Please note @silverwind's objection, however. |
|
So this is a usability/docs note. While it makes sense to use ^C after used once, the idea is to educate the user that |
|
I did learn from this the existence of |
|
Wow, I learned something today. But I would rephrase "use" to something like "type". The first impression I had when reading "use .exit" was that it would mean "use the process.exit method". I am however completely missing the point of the existence of .exit. What's the use case? My fingers are already on the CTRL-C buttons, why would I start typing ".exit" instead? |
|
I second @silverwind here. Normally when I press Ctrl + C (or Ctrl + D), I expect the program to terminate. But, if it doesn't then I would expect some valid message being shown to me. In this case, the message being printed looks perfectly fine to me. |
|
Considering this is only on an interrupt, I'm not sure if it makes sense? |
^ +1
Not sure
Agree! |
|
@hemanth ... this is a good step, but I think something like the following would be better: |
|
+1 to @jasnell 's wording. |
|
@hemanth ... would you be able/willing to update the PR with the suggested wording in #3368 (comment)? |
|
@jasnell Done. |
|
LGTM! |
|
Oh... one last thing... can you squash the commits and fix up the commit log to follow the standard format? https://github.com/nodejs/node/blob/master/CONTRIBUTING.md#step-3-commit |
When the user hits `^C` in the REPL show more info about `.exit`. The idea was to give more info to the user when they hit ^C. Current version just displays `(^C again to quit)` and most of the users are not aware of the `.exit` command that would Exit the repl.
|
@jasnell Looks fine now? |
|
Yes perfect. Thank you! |
When the user hits `^C` in the REPL show more info about `.exit`. The idea was to give more info to the user when they hit ^C. Current version just displays `(^C again to quit)` and most of the users are not aware of the `.exit` command that would Exit the repl. PR-URL: #3368 Reviewed-By: James M Snell <jasnell@gmail.com>
|
Landed in 354f9ce |
|
👍 Thanks! |
When the user hits `^C` in the REPL show more info about `.exit`. The idea was to give more info to the user when they hit ^C. Current version just displays `(^C again to quit)` and most of the users are not aware of the `.exit` command that would Exit the repl. PR-URL: #3368 Reviewed-By: James M Snell <jasnell@gmail.com>
When the user hits `^C` in the REPL show more info about `.exit`. The idea was to give more info to the user when they hit ^C. Current version just displays `(^C again to quit)` and most of the users are not aware of the `.exit` command that would Exit the repl. PR-URL: #3368 Reviewed-By: James M Snell <jasnell@gmail.com>
|
landed in lts-v4.x-staging as bf48969 |
|
👍 Thanks. |
When the user hits `^C` in the REPL show more info about `.exit`. The idea was to give more info to the user when they hit ^C. Current version just displays `(^C again to quit)` and most of the users are not aware of the `.exit` command that would Exit the repl. PR-URL: #3368 Reviewed-By: James M Snell <jasnell@gmail.com>
When the user hits `^C` in the REPL show more info about `.exit`. The idea was to give more info to the user when they hit ^C. Current version just displays `(^C again to quit)` and most of the users are not aware of the `.exit` command that would Exit the repl. PR-URL: #3368 Reviewed-By: James M Snell <jasnell@gmail.com>
When the user hits `^C` in the REPL show more info about `.exit`. The idea was to give more info to the user when they hit ^C. Current version just displays `(^C again to quit)` and most of the users are not aware of the `.exit` command that would Exit the repl. PR-URL: #3368 Reviewed-By: James M Snell <jasnell@gmail.com>
10 participants
^