events: remove NodeEventTarget

[jasnell]

The extending of EventTarget with EventEmitter emulation is contentious
and not something that is strictly necessary for minimal support.

/cc @benjamingr

Signed-off-by: James M Snell jasnell@gmail.com

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• tests and/or benchmarks are included
• documentation is changed or added
• commit message follows commit guidelines

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/31664/

[benjamingr]

Changes LGTM though I do see value in exposing this like we expose Buffer on top of types arrays.

Where did this get pushback?

[targos]

I do not think this is comparable to Buffer, because Buffer existed in Node.js before typed arrays. EventTarget is a new API and nothing in the ecosystem can rely on NodeEventTarget yet because it was never released.

[addaleax]

Fwiw, I’m somewhat under the impression that this would make turning MessagePorts into actual EventTargets easier – because right now, MessagePorts do implement the EventEmitter API, but only a relatively small subset of the EventTarget API.

Or, put another way: It would require something like NodeEventTarget, whether that’s exposed as a public API or not.

(There’s also the question of whether it’s possible to perform that change to MessagePort without non-trivial performance impact, and whether we’d want to do it at all if the performance impact turns out to be significant.)

[jasnell]

We can hold off on this if there is other places we can use it. The pushback that I've seen in really in the places we'd use it... like AbortSignal ... e.g. can we extend that interface and still call it AbortSignal? For now, I'll close this PR but I'll open another that removes the removeAllListeners from it

[benjamingr]

e.g. can we extend that interface and still call it AbortSignal?

I like the approach we took with NodeEventTarget and we can take a similar approach for AbortController - fwiw there are cases in the DOM That extend AbortController already (like the TaskController API for postTask.