Conversation
nodejs-github-bot
added
doc
addaleax
left a comment
addaleax
left a comment
There was a problem hiding this comment.
LGTM with the linter failures addressed
BridgeAR
added
the
author ready
BridgeAR
force-pushed
the
master
branch
2 times, most recently
from
8ae28ff to
2935f72
Compare
|
Just note. you actually don’t need wabt or wat2wasm tools. You may use webassembly extension for vscode to compile wat to wasm. |
@reklatsmasters VSCode webassembly extension uses wabt as a dependency (see package.json), which is a JS port of wabt. Moreover, I don't think VSCode extension is a standard way of compiling |
|
Landed in f5ec98c, thanks for the PR! 🎉 |
- Code sample updated by adding a hello-world (`demo.wat`) code example - Step for compiling `.wat` to `.wasm` added (with reference to `wabt` tools) - The sample code prints "hello world\n" in the console Note: This update adds a very minimal change to the existing sample and can be treated as an extension. PR-URL: #33626 Reviewed-By: Anna Henningsen <anna@addaleax.net>
|
Actually, I had to back this out of master because this conflicts with the linter rules introduced by 0ef6956 … @Trott or @DerekNonGeneric Could you push a fixup commit to this PR and then land this? I’m not sure what the linter expects here myself. |
I'll make a judgment call and push a fixup commit (and then land, and then open a PR to get the lint presets updated if appropriate). |
|
Fixed-up and force-pushed. |
|
All the linters came back green. Landing. |
|
Landed in 343cf1b |
- Code sample updated by adding a hello-world (`demo.wat`) code example - Step for compiling `.wat` to `.wasm` added (with reference to `wabt` tools) - The sample code prints "hello world\n" in the console This update adds a very minimal change to the existing sample and can be treated as an extension. PR-URL: #33626 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com>
- Code sample updated by adding a hello-world (`demo.wat`) code example - Step for compiling `.wat` to `.wasm` added (with reference to `wabt` tools) - The sample code prints "hello world\n" in the console This update adds a very minimal change to the existing sample and can be treated as an extension. PR-URL: #33626 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com>
- Code sample updated by adding a hello-world (`demo.wat`) code example - Step for compiling `.wat` to `.wasm` added (with reference to `wabt` tools) - The sample code prints "hello world\n" in the console This update adds a very minimal change to the existing sample and can be treated as an extension. PR-URL: #33626 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com>
- Code sample updated by adding a hello-world (`demo.wat`) code example - Step for compiling `.wat` to `.wasm` added (with reference to `wabt` tools) - The sample code prints "hello world\n" in the console This update adds a very minimal change to the existing sample and can be treated as an extension. PR-URL: #33626 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com>
- Code sample updated by adding a hello-world (`demo.wat`) code example - Step for compiling `.wat` to `.wasm` added (with reference to `wabt` tools) - The sample code prints "hello world\n" in the console This update adds a very minimal change to the existing sample and can be treated as an extension. PR-URL: #33626 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com>
6 participants
wasi: update code sample
Code sample updated by adding a hello-world (
demo.wat) code example. Step for compiling.watto.wasmadded (with reference towabttools). The sample code prints "hello world\n" in the console. Note: This update can be treated as an extension to the existing sample.Checklist