events: fix event-target enumerable keys#33616
Closed
benjamingr wants to merge 1 commit intonodejs:masterfrom
Closed
events: fix event-target enumerable keys#33616benjamingr wants to merge 1 commit intonodejs:masterfrom
benjamingr wants to merge 1 commit intonodejs:masterfrom
Conversation
benjamingr
added
the
events
Member
Author
|
Verified with Anne that this is the correct behavior - here is the relevant reference https://heycam.github.io/webidl/#define-the-unforgeable-regular-attributes |
jasnell
reviewed
May 28, 2020
|
|
||
| { | ||
| const ev = new Event('foo'); | ||
| deepStrictEqual(Object.keys(ev), ['isTrusted']); |
Member
There was a problem hiding this comment.
should this include a test that the value cannot be changed? I assume that's likely covered in the WPT tho?
Member
Author
There was a problem hiding this comment.
jasnell
approved these changes
May 28, 2020
BridgeAR
approved these changes
May 28, 2020
Collaborator
BridgeAR
added
the
author ready
Collaborator
addaleax
approved these changes
May 29, 2020
Member
|
Experimental fixups to an unreleased feature... 👍 to fast track |
Member
|
Landed in 2d071e7 |
BridgeAR
pushed a commit
to BridgeAR/node
that referenced
this pull request
May 30, 2020
PR-URL: nodejs#33616 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Anna Henningsen <anna@addaleax.net>
codebytere
pushed a commit
that referenced
this pull request
Jun 18, 2020
PR-URL: #33616 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Merged
codebytere
pushed a commit
that referenced
this pull request
Jun 30, 2020
PR-URL: #33616 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Anna Henningsen <anna@addaleax.net>
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Another quick one as I look for deltas before adding the WPTs.
TIL about https://heycam.github.io/webidl/#LegacyUnforgeable
Also I asked about this behavior on #whatwg to make sure I got it right (Edge behaves differently from Chrome and Firefox here)
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes