events: variable originalListener is useless#33596
Closed
fuxingZhang wants to merge 1 commit intonodejs:masterfrom
fuxingZhang:patch-1
Closed
events: variable originalListener is useless#33596fuxingZhang wants to merge 1 commit intonodejs:masterfrom fuxingZhang:patch-1
fuxingZhang wants to merge 1 commit intonodejs:masterfrom
fuxingZhang:patch-1
Conversation
nodejs-github-bot
added
the
events
Collaborator
bnoordhuis
approved these changes
May 28, 2020
Member
bnoordhuis
left a comment
bnoordhuis
left a comment
There was a problem hiding this comment.
It's tautologically true so good catch. :-)
jasnell
approved these changes
May 28, 2020
BridgeAR
approved these changes
May 28, 2020
ZYSzys
approved these changes
May 28, 2020
BridgeAR
added
the
author ready
Collaborator
cjihrig
approved these changes
May 30, 2020
jasnell
pushed a commit
that referenced
this pull request
May 30, 2020
PR-URL: #33596 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Member
|
Landed in c45f881 |
codebytere
pushed a commit
that referenced
this pull request
Jun 18, 2020
PR-URL: #33596 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Merged
codebytere
pushed a commit
that referenced
this pull request
Jun 30, 2020
PR-URL: #33596 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
addaleax
pushed a commit
that referenced
this pull request
Sep 22, 2020
PR-URL: #33596 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesCurrent tests are sufficient, no new tests are required