Skip to content

src: don't use semicolon outside function#33592

Closed
codebytere wants to merge 1 commit intonodejs:masterfrom
codebytere:no-semi
Closed

src: don't use semicolon outside function#33592
codebytere wants to merge 1 commit intonodejs:masterfrom
codebytere:no-semi

Conversation

@codebytere
Copy link
Member

@codebytere codebytere commented May 27, 2020

This causes a build error in Electron:

../../third_party/electron_node/src/node_watchdog.cc:435:73: error: extra ';' outside of a function is incompatible with C++98 [-Werror,-Wc++98-compat-extra-semi]
NODE_MODULE_CONTEXT_AWARE_INTERNAL(watchdog, node::watchdog::Initialize);
                                                                        ^
1 error generated.
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@codebytere codebytere requested a review from legendecas May 27, 2020 19:25
@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label May 27, 2020
mhdawson
mhdawson approved these changes May 27, 2020
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented May 27, 2020

CI: https://ci.nodejs.org/job/node-test-pull-request/31586/

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 27, 2020
@codebytere
Copy link
Member Author

codebytere commented May 28, 2020

This might be the most absurd PR i've raised so far 😆

@codebytere
Copy link
Member Author

codebytere commented May 29, 2020

Landed in 0ff3819

@codebytere codebytere closed this May 29, 2020
codebytere added a commit that referenced this pull request May 29, 2020
@codebytere
src: don't use semicolon outside function
0ff3819 
PR-URL: #33592
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Matheus Marchini <mat@mmarchini.me>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Zeyu Yang <himself65@outlook.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@codebytere codebytere deleted the no-semi branch May 29, 2020 19:45
codebytere added a commit that referenced this pull request Jun 18, 2020
@codebytere
src: don't use semicolon outside function
522fbbc 
PR-URL: #33592
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Matheus Marchini <mat@mmarchini.me>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Zeyu Yang <himself65@outlook.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@codebytere codebytere mentioned this pull request Jun 28, 2020
Merged
codebytere added a commit that referenced this pull request Jun 30, 2020
@codebytere
src: don't use semicolon outside function
0e7d26c 
PR-URL: #33592
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Matheus Marchini <mat@mmarchini.me>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Zeyu Yang <himself65@outlook.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
codebytere added a commit that referenced this pull request Jul 8, 2020
@codebytere
src: don't use semicolon outside function
9c69296 
PR-URL: #33592
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Matheus Marchini <mat@mmarchini.me>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Zeyu Yang <himself65@outlook.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@codebytere codebytere mentioned this pull request Jul 13, 2020
Merged
codebytere added a commit to electron/electron that referenced this pull request Jul 23, 2020
@codebytere
src: don't use semicolon outside function
63b5950 
nodejs/node#33592
codebytere added a commit to electron/electron that referenced this pull request Jul 24, 2020
@codebytere
src: don't use semicolon outside function
59fcb1a 
nodejs/node#33592
codebytere added a commit to electron/electron that referenced this pull request Jul 24, 2020
@codebytere
src: don't use semicolon outside function
bc98d4e 
nodejs/node#33592
codebytere added a commit to electron/electron that referenced this pull request Jul 24, 2020
@codebytere
src: don't use semicolon outside function
206d62b 
nodejs/node#33592
This was referenced Jan 25, 2022
Open
Open
Open
Open
Open
Open
Open
Open
Open
@snyk-bot snyk-bot mentioned this pull request Sep 27, 2022
Open
@wedataintelligence wedataintelligence mentioned this pull request Sep 27, 2022
Open
This was referenced Sep 27, 2022
Open
Open
@137717unity 137717unity mentioned this pull request Sep 28, 2022
Open
@snyk-bot snyk-bot mentioned this pull request Sep 28, 2022
Open
@ron-a20 ron-a20 mentioned this pull request Sep 28, 2022
Open
This was referenced Sep 28, 2022
Open
Open
@137717unity 137717unity mentioned this pull request Jun 23, 2023
Open
@molllyn1 molllyn1 mentioned this pull request Jun 23, 2023
Open
@aliceUnhinged613 aliceUnhinged613 mentioned this pull request Jun 24, 2023
Open
@ron-a20 ron-a20 mentioned this pull request Jun 24, 2023
Open
@wedataintelligence wedataintelligence mentioned this pull request Jun 24, 2023
Open
@aliceUnhinged613 aliceUnhinged613 mentioned this pull request Nov 25, 2023
Open
@wedataintelligence wedataintelligence mentioned this pull request Nov 28, 2023
Open
@baby636 baby636 mentioned this pull request Dec 7, 2023
Open
This was referenced Dec 15, 2023
Open
Open
@baby636 baby636 mentioned this pull request Jan 6, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes

@addaleax addaleax addaleax approved these changes

@benjamingr benjamingr benjamingr approved these changes

@richardlau richardlau richardlau approved these changes

@legendecas legendecas legendecas approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@mhdawson mhdawson mhdawson approved these changes

@himself65 himself65 himself65 approved these changes

@juanarbol juanarbol juanarbol approved these changes

+2 more reviewers

@mmarchini mmarchini mmarchini approved these changes

@MarshallOfSound MarshallOfSound MarshallOfSound approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.