n-api: remove napi_env::CallIntoModuleThrow#33570
Closed
gabrielschulhof wants to merge 3 commits intonodejs:masterfrom
Closed
n-api: remove napi_env::CallIntoModuleThrow#33570gabrielschulhof wants to merge 3 commits intonodejs:masterfrom
napi_env::CallIntoModuleThrow#33570gabrielschulhof wants to merge 3 commits intonodejs:masterfrom
Conversation
Give `napi_env::CallIntoModule` the thrower used by `CallIntoModuleThrow` as its default second argument. That way we do not need two different methods on `napi_env` for calling into the addon.
gabrielschulhof
added
c++
3 tasks
addaleax
reviewed
May 26, 2020
Contributor
Author
|
@addaleax I have made the changes you requested. |
addaleax
approved these changes
May 26, 2020
Collaborator
BridgeAR
added
the
author ready
Collaborator
legendecas
approved these changes
May 27, 2020
gabrielschulhof
removed
the
i18n-api
jasnell
approved these changes
May 27, 2020
Member
|
CI looks, good will plan to land tomorrow afternoon once 24 hours is up. |
gabrielschulhof
pushed a commit
that referenced
this pull request
May 28, 2020
Give `napi_env::CallIntoModule` the thrower used by `CallIntoModuleThrow` as its default second argument. That way we do not need two different methods on `napi_env` for calling into the addon. PR-URL: #33570 Signed-off-by: Gabriel Schulhof <gabriel.schulhof@intel.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Contributor
Author
Member
|
@gabrielschulhof Thanks ! |
gabrielschulhof
pushed a commit
to gabrielschulhof/node
that referenced
this pull request
Jun 9, 2020
Give `napi_env::CallIntoModule` the thrower used by `CallIntoModuleThrow` as its default second argument. That way we do not need two different methods on `napi_env` for calling into the addon. PR-URL: nodejs#33570 Signed-off-by: Gabriel Schulhof <gabriel.schulhof@intel.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
3 tasks
3 tasks
codebytere
pushed a commit
that referenced
this pull request
Jun 18, 2020
Give `napi_env::CallIntoModule` the thrower used by `CallIntoModuleThrow` as its default second argument. That way we do not need two different methods on `napi_env` for calling into the addon. PR-URL: #33570 Signed-off-by: Gabriel Schulhof <gabriel.schulhof@intel.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Merged
codebytere
pushed a commit
that referenced
this pull request
Jun 30, 2020
Give `napi_env::CallIntoModule` the thrower used by `CallIntoModuleThrow` as its default second argument. That way we do not need two different methods on `napi_env` for calling into the addon. PR-URL: #33570 Signed-off-by: Gabriel Schulhof <gabriel.schulhof@intel.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
codebytere
pushed a commit
that referenced
this pull request
Jul 8, 2020
Give `napi_env::CallIntoModule` the thrower used by `CallIntoModuleThrow` as its default second argument. That way we do not need two different methods on `napi_env` for calling into the addon. PR-URL: #33570 Signed-off-by: Gabriel Schulhof <gabriel.schulhof@intel.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Give
napi_env::CallIntoModulethe thrower used byCallIntoModuleThrowas its default second argument. That way we donot need two different methods on
napi_envfor calling into theaddon.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesRe: #33508