tools: update check-imports using function#33565
Closed
danbev wants to merge 2 commits intonodejs:masterfrom
Closed
tools: update check-imports using function#33565danbev wants to merge 2 commits intonodejs:masterfrom
danbev wants to merge 2 commits intonodejs:masterfrom
Conversation
Currently, the do_exist function that performs the checks for unused types declared with using declarations, only matches the name of the using declarations. The means that some unused using declarations are not detected. For example having both a 'using Maybe;' and a 'using MaybeLocal' and only using MaybeLocal would not be reported. This commit attempts to take into account the above mentioned case and also others where the name of the using declaration type is used in name of a variables or function call. For example, 'using Just;', will now be reported as unused even if there are calls to the FromJust function.
This commit removes the unused using declarations reported by lint-cpp.
Member
Contributor
Author
|
@richardlau Sorry, for some reason I though that had already been merged. Closing this. |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the
do_existfunction that performs the checks for unusedtypes declared with using declarations, only matches the name of the
using declarations. The means that some unused using declarations are
not detected. For example having both a
using Maybe;and ausing MaybeLocaland only usingMaybeLocalwould not be reported.This commit attempts to take into account the above mentioned case and
also others where the name of the using declaration type is used in name
of a variables or function call. For example,
using Just;, will now bereported as unused even if there are calls to the
FromJustfunction.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes