Skip to content

console: fix console names#33524

Closed
BridgeAR wants to merge 5 commits intonodejs:masterfrom
BridgeAR:fix-console-names
Closed

console: fix console names#33524
BridgeAR wants to merge 5 commits intonodejs:masterfrom
BridgeAR:fix-console-names

Conversation

@BridgeAR
Copy link
Member

@BridgeAR BridgeAR commented May 23, 2020 •
edited
Loading

Before:

image

After:

image

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

BridgeAR added 3 commits May 23, 2020 03:00
@BridgeAR
console: remove dead code
1f0453a 
This check is always truthy. Thus, it's removed.

Signed-off-by: Ruben Bridgewater <ruben@bridgewater.de>
@BridgeAR
console: mark special console properties as non-enumerable
60b8282 
This makes sure internal console properties are not visible during
default inspection. They are still visible when inspecting the
console with `showHidden` set to `true`.

These properties are confusing while working with the REPL and easily
show up.

Signed-off-by: Ruben Bridgewater <ruben@bridgewater.de>
@BridgeAR
console: name console functions appropriately
ac84573 
The current name of most of the global console functions is
"bound consoleCall". This is changed to the actual functions name
e.g., "log" or "error".

Signed-off-by: Ruben Bridgewater <ruben@bridgewater.de>
@nodejs-github-bot nodejs-github-bot added console Issues and PRs related to the console subsystem. util Issues and PRs related to the built-in util module. labels May 23, 2020
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented May 23, 2020

CI: https://ci.nodejs.org/job/node-test-pull-request/31478/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented May 23, 2020

CI: https://ci.nodejs.org/job/node-test-pull-request/31491/

@BridgeAR
fixup! console: name console functions appropriately
06defb0 
Robuster tests (e.g, no inspector)

Signed-off-by: Ruben Bridgewater <ruben@bridgewater.de>
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented May 23, 2020

CI: https://ci.nodejs.org/job/node-test-pull-request/31496/

@BridgeAR
fixup! console: name console functions appropriately
dab9b92 
Signed-off-by: Ruben Bridgewater <ruben@bridgewater.de>
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented May 23, 2020 •
edited by BridgeAR
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/31525/ 💛 (known flake: test-http2-reset-flood)

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 23, 2020
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented May 28, 2020

CI: https://ci.nodejs.org/job/node-test-pull-request/31608/

BridgeAR added a commit to BridgeAR/node that referenced this pull request May 30, 2020
@BridgeAR
console: remove dead code
b61249e 
This check is always truthy. Thus, it's removed.

Signed-off-by: Ruben Bridgewater <ruben@bridgewater.de>

PR-URL: nodejs#33524
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
BridgeAR added a commit to BridgeAR/node that referenced this pull request May 30, 2020
@BridgeAR
console: mark special console properties as non-enumerable
87629d7 
This makes sure internal console properties are not visible during
default inspection. They are still visible when inspecting the
console with `showHidden` set to `true`.

These properties are confusing while working with the REPL and easily
show up.

Signed-off-by: Ruben Bridgewater <ruben@bridgewater.de>

PR-URL: nodejs#33524
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
BridgeAR added a commit to BridgeAR/node that referenced this pull request May 30, 2020
@BridgeAR
console: name console functions appropriately
4bdab88 
The current name of most of the global console functions is
"bound consoleCall". This is changed to the actual functions name
e.g., "log" or "error".

Signed-off-by: Ruben Bridgewater <ruben@bridgewater.de>

PR-URL: nodejs#33524
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
@BridgeAR
Copy link
Member Author

BridgeAR commented May 30, 2020

Landed in 6cc94b2...4bdab88

@BridgeAR BridgeAR closed this May 30, 2020
codebytere pushed a commit that referenced this pull request Jun 18, 2020
@BridgeAR @codebytere
console: remove dead code
bce9986 
This check is always truthy. Thus, it's removed.

Signed-off-by: Ruben Bridgewater <ruben@bridgewater.de>

PR-URL: #33524
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
codebytere pushed a commit that referenced this pull request Jun 18, 2020
@BridgeAR @codebytere
console: mark special console properties as non-enumerable
9d24f71 
This makes sure internal console properties are not visible during
default inspection. They are still visible when inspecting the
console with `showHidden` set to `true`.

These properties are confusing while working with the REPL and easily
show up.

Signed-off-by: Ruben Bridgewater <ruben@bridgewater.de>

PR-URL: #33524
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
codebytere pushed a commit that referenced this pull request Jun 18, 2020
@BridgeAR @codebytere
console: name console functions appropriately
a6a74ae 
The current name of most of the global console functions is
"bound consoleCall". This is changed to the actual functions name
e.g., "log" or "error".

Signed-off-by: Ruben Bridgewater <ruben@bridgewater.de>

PR-URL: #33524
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
@codebytere codebytere mentioned this pull request Jun 28, 2020
Merged
codebytere pushed a commit that referenced this pull request Jun 30, 2020
@BridgeAR @codebytere
console: remove dead code
3b3621b 
This check is always truthy. Thus, it's removed.

Signed-off-by: Ruben Bridgewater <ruben@bridgewater.de>

PR-URL: #33524
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
codebytere pushed a commit that referenced this pull request Jun 30, 2020
@BridgeAR @codebytere
console: mark special console properties as non-enumerable
71cabcd 
This makes sure internal console properties are not visible during
default inspection. They are still visible when inspecting the
console with `showHidden` set to `true`.

These properties are confusing while working with the REPL and easily
show up.

Signed-off-by: Ruben Bridgewater <ruben@bridgewater.de>

PR-URL: #33524
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
codebytere pushed a commit that referenced this pull request Jun 30, 2020
@BridgeAR @codebytere
console: name console functions appropriately
1356211 
The current name of most of the global console functions is
"bound consoleCall". This is changed to the actual functions name
e.g., "log" or "error".

Signed-off-by: Ruben Bridgewater <ruben@bridgewater.de>

PR-URL: #33524
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
codebytere pushed a commit that referenced this pull request Jul 8, 2020
@BridgeAR @codebytere
console: remove dead code
80782cb 
This check is always truthy. Thus, it's removed.

Signed-off-by: Ruben Bridgewater <ruben@bridgewater.de>

PR-URL: #33524
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
codebytere pushed a commit that referenced this pull request Jul 8, 2020
@BridgeAR @codebytere
console: mark special console properties as non-enumerable
d8365bc 
This makes sure internal console properties are not visible during
default inspection. They are still visible when inspecting the
console with `showHidden` set to `true`.

These properties are confusing while working with the REPL and easily
show up.

Signed-off-by: Ruben Bridgewater <ruben@bridgewater.de>

PR-URL: #33524
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
codebytere pushed a commit that referenced this pull request Jul 8, 2020
@BridgeAR @codebytere
console: name console functions appropriately
a9c5b33 
The current name of most of the global console functions is
"bound consoleCall". This is changed to the actual functions name
e.g., "log" or "error".

Signed-off-by: Ruben Bridgewater <ruben@bridgewater.de>

PR-URL: #33524
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
@codebytere codebytere mentioned this pull request Jul 13, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes

@targos targos targos approved these changes

+1 more reviewer

@antsmartian antsmartian antsmartian approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. console Issues and PRs related to the console subsystem. util Issues and PRs related to the built-in util module.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@BridgeAR @nodejs-github-bot @jasnell @antsmartian @targos