http2: [compat api] add writable* properties#33506
Closed
rexagod wants to merge 3 commits intonodejs:masterfrom
Closed
http2: [compat api] add writable* properties#33506rexagod wants to merge 3 commits intonodejs:masterfrom
rexagod wants to merge 3 commits intonodejs:masterfrom
Conversation
added writableHighWaterMark, writableLength, and writableFinished properties with test. Refs: nodejs#29829
ronag
reviewed
May 24, 2020
| } | ||
|
|
||
| get writableFinished() { | ||
| return this[kStream].writableFinished; |
Member
There was a problem hiding this comment.
I suspect this will need a special case and test for state.headRequest.
Member
There was a problem hiding this comment.
Though I think headRequest is slightly broken or maybe I don't understand it. There is special handling for it in Http2ServerResponse.end() but not in Http2ServerResponse.write()? Not sure who is a good ping there. @jasnell?
Member
Author
There was a problem hiding this comment.
EDIT: please create an issue if landing this PR without resolving this.
Issue: #33543
ronag
reviewed
May 24, 2020
Collaborator
BridgeAR
added
the
author ready
lpinca
approved these changes
May 24, 2020
Co-authored-by: Luigi Pinca <luigipinca@gmail.com>
Collaborator
BridgeAR
approved these changes
May 30, 2020
BridgeAR
pushed a commit
to BridgeAR/node
that referenced
this pull request
May 30, 2020
added writableHighWaterMark, writableLength, and writableFinished properties with test. Refs: nodejs#29829 PR-URL: nodejs#33506 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Member
|
Landed in 99abaf9 |
32 tasks
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
added writableHighWaterMark, writableLength, and writableFinished
properties with test.
Refs: #29829 (9th, 10th, and 11th sub-issues)
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes