fs: unify style in preprocessSymlinkDestination#33496
Closed
bzoz wants to merge 1 commit intonodejs:masterfrom
Closed
fs: unify style in preprocessSymlinkDestination#33496bzoz wants to merge 1 commit intonodejs:masterfrom
bzoz wants to merge 1 commit intonodejs:masterfrom
Conversation
Removes the else after return to match rest of the style of the function.
nodejs-github-bot
added
the
fs
cjihrig
approved these changes
May 21, 2020
jasnell
approved these changes
May 22, 2020
BridgeAR
approved these changes
May 23, 2020
Collaborator
BridgeAR
pushed a commit
to BridgeAR/node
that referenced
this pull request
May 23, 2020
Removes the else after return to match rest of the style of the function. PR-URL: nodejs#33496 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Member
|
Landed in 4a911d4 🎉 |
codebytere
pushed a commit
that referenced
this pull request
Jun 18, 2020
Removes the else after return to match rest of the style of the function. PR-URL: #33496 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
codebytere
pushed a commit
that referenced
this pull request
Jun 18, 2020
Removes the else after return to match rest of the style of the function. PR-URL: #33496 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Merged
codebytere
pushed a commit
that referenced
this pull request
Jun 30, 2020
Removes the else after return to match rest of the style of the function. PR-URL: #33496 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
codebytere
pushed a commit
that referenced
this pull request
Jul 8, 2020
Removes the else after return to match rest of the style of the function. PR-URL: #33496 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the else after return to match rest of the style of the function.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes