docs: CommonJS self-resolve spec correction#33391
Closed
guybedford wants to merge 1 commit intomasterfrom
Closed
Conversation
nodejs-github-bot
added
doc
jasnell
approved these changes
May 14, 2020
GeoffreyBooth
approved these changes
May 22, 2020
Collaborator
Collaborator
GeoffreyBooth
pushed a commit
that referenced
this pull request
May 23, 2020
PR-URL: #33391 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Geoffrey Booth <webmaster@geoffreybooth.com>
Member
|
Landed in e88d098 |
codebytere
pushed a commit
that referenced
this pull request
Jun 18, 2020
PR-URL: #33391 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Geoffrey Booth <webmaster@geoffreybooth.com>
Merged
codebytere
pushed a commit
that referenced
this pull request
Jun 30, 2020
PR-URL: #33391 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Geoffrey Booth <webmaster@geoffreybooth.com>
codebytere
pushed a commit
that referenced
this pull request
Jul 8, 2020
PR-URL: #33391 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Geoffrey Booth <webmaster@geoffreybooth.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The package self-resolution spec in the CJS docs effectively has an editorial correction here. If this was followed to the word any package.json with
"exports"would never be able to load a dependency from node_modules :)This updates the spec to match what is implemented and what the intent of the spec was.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes