test: remove util from child-process test#3336
Closed
MylesBorins wants to merge 1 commit intonodejs:masterfrom
MylesBorins:removeUtilSpawnSync
Closed
test: remove util from child-process test#3336MylesBorins wants to merge 1 commit intonodejs:masterfrom MylesBorins:removeUtilSpawnSync
MylesBorins wants to merge 1 commit intonodejs:masterfrom
MylesBorins:removeUtilSpawnSync
Conversation
Simple PR inspired by #3324 Util is being used in test-child-process-spawnsync-input.js for string templating. This PR replaces that with a template string.s
Contributor
Author
Member
|
LGTM |
Member
|
LGTM if CI is happy |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simple PR inspired by #3324
Util is being used in test-child-process-spawnsync-input.js for string templating.
This PR replaces that with a template string.s