http2: Reuse ._onTimeout() to Http2Session and Http2Stream classes#33354
Closed
rickyes wants to merge 2 commits intonodejs:masterfrom
Closed
http2: Reuse ._onTimeout() to Http2Session and Http2Stream classes#33354rickyes wants to merge 2 commits intonodejs:masterfrom
rickyes wants to merge 2 commits intonodejs:masterfrom
Conversation
benjamingr
reviewed
May 11, 2020
benjamingr
reviewed
May 11, 2020
benjamingr
approved these changes
May 11, 2020
Member
|
@yashLadha hey: you deleted my comment, I'm a bit confused and not not entirely sure how that's possible :] Would you mind explaining what happened I'm a bit baffled? |
Contributor
|
@benjamingr After I commented, i checked out code locally and saw that the method is a class method and after which I deleted my commented. Don't know why your comment got deleted 😕. I was not able to see your comment when I deleted my comment. Probably I haven't refreshed the page. Sorry for any confusion it caused. |
Contributor
|
Also I think there is some hook in NodeJS repo because i deleted my comment only 😕 |
Member
|
@benjamingr I guess it's a github bug. I reported it to github to have a closer look. |
BridgeAR
approved these changes
May 23, 2020
BridgeAR
added
the
author ready
Collaborator
Collaborator
Member
|
Landed in 7a094dc |
BridgeAR
pushed a commit
to BridgeAR/node
that referenced
this pull request
May 23, 2020
PR-URL: nodejs#33354 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
codebytere
pushed a commit
that referenced
this pull request
Jun 18, 2020
PR-URL: #33354 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Merged
codebytere
pushed a commit
that referenced
this pull request
Jun 30, 2020
PR-URL: #33354 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
codebytere
pushed a commit
that referenced
this pull request
Jul 8, 2020
PR-URL: #33354 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes