http2: [compat api] use Object.create(null) for getHeaders#33188
Closed
rexagod wants to merge 5 commits intonodejs:masterfrom
Closed
http2: [compat api] use Object.create(null) for getHeaders#33188rexagod wants to merge 5 commits intonodejs:masterfrom
Object.create(null) for getHeaders#33188rexagod wants to merge 5 commits intonodejs:masterfrom
Conversation
refactor `getHeaders` to initialize headers using `Object.create(null)` Refs: nodejs#29829 fixup: lint
rexagod
changed the title
Object.create(null) for getHeadersObject.create(null) for getHeaders
BridgeAR
reviewed
May 3, 2020
wa-Nadoo
reviewed
May 9, 2020
BridgeAR
reviewed
May 23, 2020
Collaborator
BridgeAR
approved these changes
May 24, 2020
Member
|
This seems like a patch due to only applying to the compat mode and to align it with the former behavior. @nodejs/http @nodejs/http2 it would be great to get confirmation for that. |
BridgeAR
added
the
author ready
Collaborator
jasnell
approved these changes
May 25, 2020
sebdeckers
approved these changes
May 25, 2020
trivikr
approved these changes
May 29, 2020
Member
|
Landed in c095808 |
mcollina
pushed a commit
to mcollina/node
that referenced
this pull request
May 29, 2020
refactor `getHeaders` to initialize headers using `Object.create(null)` Refs: nodejs#29829 PR-URL: nodejs#33188 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sebastiaan Deckers <sebdeckers83@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Member
|
For some reasons I did not fully understand I messed up landing this with |
32 tasks
codebytere
pushed a commit
that referenced
this pull request
Jun 18, 2020
refactor `getHeaders` to initialize headers using `Object.create(null)` Refs: #29829 PR-URL: #33188 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sebastiaan Deckers <sebdeckers83@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Merged
codebytere
pushed a commit
that referenced
this pull request
Jun 30, 2020
refactor `getHeaders` to initialize headers using `Object.create(null)` Refs: #29829 PR-URL: #33188 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sebastiaan Deckers <sebdeckers83@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
codebytere
pushed a commit
that referenced
this pull request
Jul 8, 2020
refactor `getHeaders` to initialize headers using `Object.create(null)` Refs: #29829 PR-URL: #33188 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sebastiaan Deckers <sebdeckers83@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
refactor
getHeadersto initialize headers usingObject.create(null)Refs: #29829
fixup: lint
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes