docs: BUILDING.md - python3-distutils dependency#33174
Closed
osher wants to merge 1 commit intonodejs:masterfrom
osher:patch-2
Closed
docs: BUILDING.md - python3-distutils dependency#33174osher wants to merge 1 commit intonodejs:masterfrom osher:patch-2
osher wants to merge 1 commit intonodejs:masterfrom
osher:patch-2
Conversation
nodejs-github-bot
added
build
Ran into #30189, solved by this comment: #30189 (comment)
Contributor
Author
|
really? 😕 How do we handle flaky builds here? |
Member
|
@nodejs/documentation @nodejs/python PTAL |
bnoordhuis
approved these changes
May 3, 2020
Member
bnoordhuis
left a comment
bnoordhuis
left a comment
There was a problem hiding this comment.
The failure is a flaky test, nothing to worry about.
trivikr
approved these changes
May 7, 2020
cclauss
approved these changes
May 7, 2020
Member
|
Landed in d6913dc |
addaleax
pushed a commit
that referenced
this pull request
May 7, 2020
Ran into #30189, solved by this comment: #30189 (comment) Refs: #30189 PR-URL: #33174 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Christian Clauss <cclauss@me.com>
codebytere
pushed a commit
that referenced
this pull request
May 11, 2020
Ran into #30189, solved by this comment: #30189 (comment) Refs: #30189 PR-URL: #33174 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Christian Clauss <cclauss@me.com>
Merged
codebytere
pushed a commit
that referenced
this pull request
Jun 7, 2020
Ran into #30189, solved by this comment: #30189 (comment) Refs: #30189 PR-URL: #33174 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Christian Clauss <cclauss@me.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ran into #30189, solved by this comment:
#30189 (comment)
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes