build: fix makefile script on windows

[Hakerh400]

On Windows there is a program find.exe located in
C:\Windows\System32, which is usually in the PATH before
MSYS version of that program (required for running makefile).
The Windows version of the program uses different CLI syntax,
which results in errors like

File not found - *node_modules*

This commit specifies the full path to the program, which is also
properly handled by MSYS on Windows.

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• commit message follows commit guidelines

[addaleax]

@nodejs/build-files

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/31092/

[bnoordhuis]

I started a CI run. I think the problem here might be that not all systems have find(1) in /usr/bin, or it's not the flavor we want.

[richardlau]

We should not hardcode absolute paths to commands in the Makefile.

The conventional way to allow overriding of commands in a Makefile is to use variables, e.g. for Python:

node/Makefile

Line 4 in 2cd7970

PYTHON ?= python

and then specify the variable when running make, e.g. make PYTHON=/my/path/python. You could then also get the configure script to determine values for the variables and write them to config.mk if you want to avoid specifying the variable every time:

node/configure.py

Lines 1781 to 1801 in 2cd7970

	# Not needed for trivial case. Useless when it's a win32 path.
	if sys.executable != 'python' and ':\\' not in sys.executable:
	config['PYTHON'] = sys.executable
	if options.prefix:
	config['PREFIX'] = options.prefix
	if options.use_ninja:
	config['BUILD_WITH'] = 'ninja'
	config_lines = ['='.join((k,v)) for k,v in config.items()]
	# Add a blank string to get a blank line at the end.
	config_lines += ['']
	config_str = '\n'.join(config_lines)
	# On Windows there's no reason to search for a different python binary.
	bin_override = None if sys.platform == 'win32' else make_bin_override()
	if bin_override:
	config_str = 'export PATH:=' + bin_override + ':$(PATH)\n' + config_str
	write('config.mk', do_not_edit + config_str)

[Hakerh400]

@richardlau PTAL

[Hakerh400]

I started a CI run. I think the problem here might be that not all systems have find(1) in /usr/bin, or it's not the flavor we want.

That is no longer a problem. The absolute path is now used only on Windows, and MSYS itself hardcoded it into /usr/bin

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/31098/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/31117/

[Hakerh400]

friendly ping

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/31521/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/31531/ 💚

[BridgeAR]

Landed in 5e4c025

[codebytere]

Should this go back to v12.x? It'll need a manual backport if yes but feel free to remove the label if not!