doc: mark assert.CallTracker experimental#33124
Closed
BridgeAR wants to merge 1 commit intonodejs:masterfrom
Closed
doc: mark assert.CallTracker experimental#33124BridgeAR wants to merge 1 commit intonodejs:masterfrom
BridgeAR wants to merge 1 commit intonodejs:masterfrom
Conversation
Some details might still change and it would be good to get feedback from users before we mark this as stable. Signed-off-by: Ruben Bridgewater <ruben@bridgewater.de>
nodejs-github-bot
added
assert
Member
|
Won't block this but I don't see it as strictly necessary. If additional useful changes are to be made, then let's identify those and get them in. It's still brand new API that |
himself65
approved these changes
Apr 28, 2020
Trott
approved these changes
May 1, 2020
Member
There was a problem hiding this comment.
Doing this is a very good idea. My big concern with pretty much all new APIS is that we may find that we've made an API design mistake. Once people start using it, it may become apparent that there is a more ergonomic way to do things. And I'm also often concerned that we may not name APIs the best we can. Let's leave ourselves a little wiggle room for a few releases. If it goes out as Experimental in, say, 14.2.0, we can always remove Experimental in a later 14.x release.
BridgeAR
added
the
author ready
targos
approved these changes
May 4, 2020
targos
pushed a commit
that referenced
this pull request
May 4, 2020
Some details might still change and it would be good to get feedback from users before we mark this as stable. Signed-off-by: Ruben Bridgewater <ruben@bridgewater.de> PR-URL: #33124 Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
Member
|
Landed in c81e5f6 |
targos
pushed a commit
that referenced
this pull request
May 4, 2020
Some details might still change and it would be good to get feedback from users before we mark this as stable. Signed-off-by: Ruben Bridgewater <ruben@bridgewater.de> PR-URL: #33124 Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
targos
added
baking-for-lts
Member
|
This is blocked until |
addaleax
removed
backport-blocked-v12.x
baking-for-lts
addaleax
pushed a commit
that referenced
this pull request
Sep 23, 2020
Some details might still change and it would be good to get feedback from users before we mark this as stable. Signed-off-by: Ruben Bridgewater <ruben@bridgewater.de> PR-URL: #33124 Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some details might still change and it would be good to get feedback
from users before we mark this as stable.
It might for example be good to rework the
stackproperty.Signed-off-by: Ruben Bridgewater ruben@bridgewater.de
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes