doc: fix markdown parsing on doc/api/os.md#33067
Closed
juanarbol wants to merge 1 commit intonodejs:masterfrom
Closed
doc: fix markdown parsing on doc/api/os.md#33067juanarbol wants to merge 1 commit intonodejs:masterfrom
juanarbol wants to merge 1 commit intonodejs:masterfrom
Conversation
nodejs-github-bot
added
doc
MrHeer
approved these changes
Apr 26, 2020
rexagod
reviewed
Apr 26, 2020
Member
rexagod
left a comment
rexagod
left a comment
There was a problem hiding this comment.
Seems a bit odd. Was this due to an invalid character?
Member
Author
|
It looks like, I guess it is something with my code editor and space character, this had happened to me few times. For this fix, I have built docs and check that fixed now. |
rexagod
approved these changes
Apr 27, 2020
addaleax
approved these changes
Apr 27, 2020
Member
addaleax
left a comment
addaleax
left a comment
There was a problem hiding this comment.
LGTM but it might be worth investigating why a nbsp breaks this, it really shouldn’t do that
addaleax
added
the
author ready
Trott
approved these changes
Apr 28, 2020
addaleax
pushed a commit
that referenced
this pull request
Apr 29, 2020
PR-URL: #33067 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com>
Member
|
Landed in ed87433 |
targos
pushed a commit
that referenced
this pull request
May 4, 2020
PR-URL: #33067 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Something is wrong on MD parsing
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes