stream: finished should complete with read-only Duplex#32967
Closed
ronag wants to merge 3 commits intonodejs:masterfrom
Closed
stream: finished should complete with read-only Duplex#32967ronag wants to merge 3 commits intonodejs:masterfrom
ronag wants to merge 3 commits intonodejs:masterfrom
Conversation
If passed a Duplex where readable or writable has been explicitly disabled then don't assume 'close' will be emitted. Fixes: nodejs#32965
ronag
force-pushed
the
eos-duplex-readOnly
branch
from
427573d to
4a3d2db
Compare
Collaborator
mcollina
approved these changes
Apr 21, 2020
Member
mcollina
left a comment
mcollina
left a comment
There was a problem hiding this comment.
lgtm.
Should this go into 12, 13, 14?
Member
Author
14 |
Collaborator
Member
|
@ronag mind adding an additional test, same as the one you have but where you call .end() just before finished instead of just after also? |
Member
Author
@mafintosh Good spot. PTAL. |
Collaborator
Member
|
@nodejs/tsc it would be good to fast-track this to v14 as well. |
mafintosh
approved these changes
Apr 21, 2020
Member
|
@ronag lgtm |
ronag
added
the
author ready
Trott
approved these changes
Apr 22, 2020
juanarbol
approved these changes
Apr 23, 2020
Member
Author
|
Landed in 4eb1701 |
ronag
added a commit
that referenced
this pull request
Apr 23, 2020
If passed a Duplex where readable or writable has been explicitly disabled then don't assume 'close' will be emitted. Fixes: #32965 PR-URL: #32967 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Mathias Buus <mathiasbuus@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
ronag
added a commit
to nxtedition/node
that referenced
this pull request
Apr 23, 2020
An unfortunate overlap between two PR that by themselves pass CI but together pass a test. nodejs#32967 changes so that pipeline does not wait for 'close'. nodejs#32968 changed so that all streams are not destroyed. Which made one test fail when expected the stream to be destroyed during pipeline callback.
4 tasks
BridgeAR
pushed a commit
that referenced
this pull request
Apr 23, 2020
An unfortunate overlap between two PR that by themselves pass CI but together pass a test. #32967 changes so that pipeline does not wait for 'close'. #32968 changed so that all streams are not destroyed. Which made one test fail when expected the stream to be destroyed during pipeline callback. PR-URL: #33030 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
This was referenced Apr 25, 2020
BethGriggs
pushed a commit
that referenced
this pull request
Apr 27, 2020
If passed a Duplex where readable or writable has been explicitly disabled then don't assume 'close' will be emitted. Fixes: #32965 PR-URL: #32967 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Mathias Buus <mathiasbuus@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
BethGriggs
pushed a commit
that referenced
this pull request
Apr 27, 2020
An unfortunate overlap between two PR that by themselves pass CI but together pass a test. #32967 changes so that pipeline does not wait for 'close'. #32968 changed so that all streams are not destroyed. Which made one test fail when expected the stream to be destroyed during pipeline callback. PR-URL: #33030 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If passed a Duplex where readable or writable has been
explicitly disabled then don't assume 'close' will be
emitted.
Fixes: #32965
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes