lib: created isValidCallback validator#32665
Closed
yashLadha wants to merge 1 commit intonodejs:masterfrom
Closed
Conversation
nodejs-github-bot
added
the
timers
himself65
reviewed
Apr 5, 2020
Member
himself65
left a comment
himself65
left a comment
There was a problem hiding this comment.
-1 because we call one more stack now. and not more readable for the coder
Contributor
Author
|
@himself65 One can also say that repeating the code can be moved into one place, following DRY (Don't repeat your code). |
himself65
requested changes
Apr 5, 2020
Contributor
|
Maybe it can be moved to |
Contributor
Author
|
@rickyes nice suggestion as this error code is being consumed by other modules as well. I think changing in other modules can be taken in some other PR as not related to the scope of this PR. Will go forward with |
yashLadha
force-pushed
the
refactor/timers_callback
branch
2 times, most recently
from
a9a5337 to
7d4316e
Compare
yashLadha
changed the title
check for callback function is moved to a separate function. This piece of code is being shared by other entities as well.
yashLadha
force-pushed
the
refactor/timers_callback
branch
from
7d4316e to
7ef2f2a
Compare
addaleax
approved these changes
Apr 5, 2020
jasnell
approved these changes
Apr 7, 2020
Flarna
approved these changes
Apr 12, 2020
Collaborator
Collaborator
himself65
approved these changes
Apr 14, 2020
himself65
pushed a commit
that referenced
this pull request
Apr 14, 2020
check for callback function is moved to a separate function. This piece of code is being shared by other entities as well. PR-URL: #32665 Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Member
|
Landed in 55b4d03 |
BethGriggs
pushed a commit
that referenced
this pull request
Apr 14, 2020
check for callback function is moved to a separate function. This piece of code is being shared by other entities as well. PR-URL: #32665 Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
targos
pushed a commit
to targos/node
that referenced
this pull request
Apr 25, 2020
check for callback function is moved to a separate function. This piece of code is being shared by other entities as well. PR-URL: nodejs#32665 Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
BridgeAR
pushed a commit
that referenced
this pull request
Apr 28, 2020
check for callback function is moved to a separate function. This piece of code is being shared by other entities as well. PR-URL: #32665 Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Merged
targos
pushed a commit
that referenced
this pull request
Apr 28, 2020
check for callback function is moved to a separate function. This piece of code is being shared by other entities as well. PR-URL: #32665 Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A crucial part of the timers function is to execute the callback function, and
this check is needed by several variants of timer functions and by other modules as well. So to
isolate the checking to a comman function that can be shared by different blocks and thus no need to reimplement the samee thing.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes