test: skip crypto test on arm buildbots#32636
Closed
bnoordhuis wants to merge 0 commit intonodejs:masterfrom
Closed
test: skip crypto test on arm buildbots#32636bnoordhuis wants to merge 0 commit intonodejs:masterfrom
bnoordhuis wants to merge 0 commit intonodejs:masterfrom
Conversation
Member
|
For other computationally-expensive tests, we do this in the code: if (!common.enoughTestCpu)
common.skip('test is CPU-intensive');Maybe do that for consistency and so we don't have to remember to move the |
Member
Author
|
I somehow thought that didn't work with known_issues tests but it does. Updated, thanks for the suggestion. |
tniessen
approved these changes
Apr 3, 2020
richardlau
approved these changes
Apr 3, 2020
cjihrig
approved these changes
Apr 3, 2020
jasnell
approved these changes
Apr 3, 2020
lpinca
approved these changes
Apr 3, 2020
3 tasks
mmarchini
approved these changes
Apr 4, 2020
Contributor
|
Fast track? |
addaleax
approved these changes
Apr 4, 2020
addaleax
added
author ready
Collaborator
Trott
approved these changes
Apr 4, 2020
Member
Judging from the CI results, apparently it doesn't work. Force-pushing out my suggestion and re-running CI.... |
Trott
force-pushed
the
skip-crypto-test-on-arm
branch
from
0e4a968 to
84e86bc
Compare
This comment has been minimized.
This comment has been minimized.
Collaborator
Trott
pushed a commit
to bnoordhuis/io.js
that referenced
this pull request
Apr 4, 2020
The Raspberry Pis are too slow to run this computationally expensive test in a timely manner, it times out after 240 seconds. PR-URL: nodejs#32636 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Matheus Marchini <mat@mmarchini.me> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com>
Trott
force-pushed
the
skip-crypto-test-on-arm
branch
from
84e86bc to
251b08d
Compare
Member
|
Landed in 251b08d |
4 tasks
BethGriggs
pushed a commit
that referenced
this pull request
Apr 7, 2020
The Raspberry Pis are too slow to run this computationally expensive test in a timely manner, it times out after 240 seconds. PR-URL: #32636 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Matheus Marchini <mat@mmarchini.me> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com>
targos
pushed a commit
that referenced
this pull request
Apr 12, 2020
The Raspberry Pis are too slow to run this computationally expensive test in a timely manner, it times out after 240 seconds. PR-URL: #32636 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Matheus Marchini <mat@mmarchini.me> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com>
targos
pushed a commit
that referenced
this pull request
Apr 22, 2020
The Raspberry Pis are too slow to run this computationally expensive test in a timely manner, it times out after 240 seconds. PR-URL: #32636 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Matheus Marchini <mat@mmarchini.me> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Raspberry Pis are too slow to run this computationally expensive
test in a timely manner, it times out after 240 seconds.