benchmark: fix error on server close in AsyncLocalStorage benchmark#32503
Closed
puzpuzpuz wants to merge 1 commit intonodejs:masterfrom
Closed
benchmark: fix error on server close in AsyncLocalStorage benchmark#32503puzpuzpuz wants to merge 1 commit intonodejs:masterfrom
puzpuzpuz wants to merge 1 commit intonodejs:masterfrom
Conversation
7fda473 to
39374a2
Compare
vdeturckheim
approved these changes
Mar 26, 2020
Flarna
approved these changes
Mar 26, 2020
cjihrig
approved these changes
Mar 26, 2020
Member
Collaborator
39374a2 to
2239ecb
Compare
Member
Author
|
The test failure in |
Collaborator
Member
|
Landed in 7e664a5 |
mcollina
pushed a commit
that referenced
this pull request
Apr 2, 2020
PR-URL: #32503 Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
4 tasks
Member
Author
|
v12.x backport PR: #32318 |
BethGriggs
pushed a commit
that referenced
this pull request
Apr 7, 2020
PR-URL: #32503 Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
targos
pushed a commit
that referenced
this pull request
Apr 12, 2020
PR-URL: #32503 Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
puzpuzpuz
added a commit
to puzpuzpuz/node
that referenced
this pull request
Apr 14, 2020
PR-URL: nodejs#32503 Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
targos
pushed a commit
to targos/node
that referenced
this pull request
Apr 25, 2020
PR-URL: nodejs#32503 Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
targos
pushed a commit
that referenced
this pull request
Apr 28, 2020
PR-URL: #32503 Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
AsyncLocalStoragetype frombenchmark/async_hooks/async-resource-vs-destroy.jsby addingundefinedcheck for the store (CLS context). Before this fix it could fail when the server is closed (and ALS instance is disabled), which may lead to calls togetCLS()method of the benchmark in the following part of the request handling code:Other types within the benchmark already had similar checks, so that's why they weren't failing.
executionAsyncResourcetype. Reason: the final implementation ofexecutionAsyncResource()never returnsnull.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes