Closed
Conversation
Contributor
|
@rvagg does this fix the notarization issue? |
Member
|
Repeating from IRC: this solves the same thing as floating the term-size commit which is now documented in the "upgrading npm" doc in master, they're both using the identical binary I compiled, signed and submitted to the term-size package, so either way it solves the problem we had with the last npm upgrade overwriting the binary. For now 13.12.0 is good to go as it is with the float, but this would be equally good without the float. |
Contributor
|
I would like to fast track this |
Collaborator
Collaborator
targos
approved these changes
Mar 26, 2020
devsnek
approved these changes
Mar 26, 2020
MylesBorins
pushed a commit
that referenced
this pull request
Mar 26, 2020
PR-URL: #32495 Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Gus Caplan <me@gus.host>
Contributor
|
Landed in b2e1a01 |
MylesBorins
pushed a commit
that referenced
this pull request
Mar 26, 2020
PR-URL: #32495 Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Gus Caplan <me@gus.host>
MylesBorins
added a commit
that referenced
this pull request
Mar 26, 2020
macOS package notarization and a change in builder configuration:
The macOS binaries for this release, and future 13.x releases, are now
being compiled on macOS 10.15 (Catalina) with Xcode 11 to support
package notarization, a requirement for installing on .pkg files on
macOS 10.15 and later. Previous builds of Node.js 13.x were compiled on
macOS 10.11 (El Capitan) with Xcode 10. As binaries are still being
compiled to support a minimum of macOS 10.10 (Yosemite) we do not
anticipate this having a negative impact on Node.js 13.x users with
older versions of macOS.
Notable changes:
* build:
* macOS package notarization (Rod Vagg)
#31459
* deps:
* upgrade npm to 6.14.4 (Ruy Adorno)
#32495
* update to uvwasi 0.0.6 (Colin Ihrig)
#32309
* upgrade to libuv 1.35.0 (Colin Ihrig)
#32204
* lib:
* add --disable-proto option to cli (Gus Caplan)
#32279
* node_report:
* move diagnostic reports to stable (Colin Ihrig)
#32242
* worker:
* allow URL in Worker constructor (Antoine du HAMEL)
#31664
* util:
* use a global symbol for `util.promisify.custom` (ExE Boss)
#31672
PR-URL: #32376
MylesBorins
added a commit
that referenced
this pull request
Mar 26, 2020
macOS package notarization and a change in builder configuration:
The macOS binaries for this release, and future 13.x releases, are now
being compiled on macOS 10.15 (Catalina) with Xcode 11 to support
package notarization, a requirement for installing on .pkg files on
macOS 10.15 and later. Previous builds of Node.js 13.x were compiled on
macOS 10.11 (El Capitan) with Xcode 10. As binaries are still being
compiled to support a minimum of macOS 10.10 (Yosemite) we do not
anticipate this having a negative impact on Node.js 13.x users with
older versions of macOS.
Notable changes:
* build:
* macOS package notarization (Rod Vagg)
#31459
* deps:
* upgrade npm to 6.14.4 (Ruy Adorno)
#32495
* update to uvwasi 0.0.6 (Colin Ihrig)
#32309
* upgrade to libuv 1.35.0 (Colin Ihrig)
#32204
* lib:
* add --disable-proto option to cli (Gus Caplan)
#32279
* node_report:
* move diagnostic reports to stable (Colin Ihrig)
#32242
* worker:
* allow URL in Worker constructor (Antoine du HAMEL)
#31664
* util:
* use a global symbol for `util.promisify.custom` (ExE Boss)
#31672
PR-URL: #32376
Merged
MylesBorins
added a commit
that referenced
this pull request
Mar 26, 2020
macOS package notarization and a change in builder configuration:
The macOS binaries for this release, and future 13.x releases, are now
being compiled on macOS 10.15 (Catalina) with Xcode 11 to support
package notarization, a requirement for installing on .pkg files on
macOS 10.15 and later. Previous builds of Node.js 13.x were compiled on
macOS 10.11 (El Capitan) with Xcode 10. As binaries are still being
compiled to support a minimum of macOS 10.10 (Yosemite) we do not
anticipate this having a negative impact on Node.js 13.x users with
older versions of macOS.
Notable changes:
* build:
* macOS package notarization (Rod Vagg)
#31459
* deps:
* upgrade npm to 6.14.4 (Ruy Adorno)
#32495
* update to uvwasi 0.0.6 (Colin Ihrig)
#32309
* upgrade to libuv 1.35.0 (Colin Ihrig)
#32204
* lib:
* add --disable-proto option to cli (Gus Caplan)
#32279
* node_report:
* move diagnostic reports to stable (Colin Ihrig)
#32242
* worker:
* allow URL in Worker constructor (Antoine du HAMEL)
#31664
* util:
* use a global symbol for `util.promisify.custom` (ExE Boss)
#31672
PR-URL: #32376
MylesBorins
pushed a commit
to MylesBorins/node
that referenced
this pull request
Mar 28, 2020
PR-URL: nodejs#32495 Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Gus Caplan <me@gus.host>
MylesBorins
pushed a commit
to MylesBorins/node
that referenced
this pull request
Apr 1, 2020
PR-URL: nodejs#32495 Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Gus Caplan <me@gus.host>
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
6.14.4 (2020-03-25)
DEPENDENCIES
136832dcamkdirp@0.5.4minimist@1.2.5transitive dep to resolve security issue9c554fd8cupdate-notifier@2.5.0deep-extend@1.2.5is-ci@1.2.1is-retry-allowed@1.2.0rc@1.2.8registry-auth-token@3.4.0widest-line@2.0.18bf99b2b5#1053 deps: updates term-size to use signed binary