src: remove calls to deprecated ArrayBuffer methods

[targos]

v8::ArrayBuffer::IsExternal and v8::ArrayBuffer::Externalize are
no longer necessary.

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/29921/

[targos]

One N-API test fails:

assert.js:102
  throw new AssertionError(obj);
  ^

AssertionError [ERR_ASSERTION]: Missing expected exception.
    at /home/iojs/build/workspace/node-test-commit-linuxone/nodes/rhel7-s390x/test/js-native-api/test_typedarray/test.js:81:10
    at Array.forEach (<anonymous>)
    at Object.<anonymous> (/home/iojs/build/workspace/node-test-commit-linuxone/nodes/rhel7-s390x/test/js-native-api/test_typedarray/test.js:79:12)
    at Module._compile (internal/modules/cjs/loader.js:1202:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1222:10)
    at Module.load (internal/modules/cjs/loader.js:1051:32)
    at Function.Module._load (internal/modules/cjs/loader.js:947:14)
    at Function.executeUserEntryPoint [as runMain] (internal/modules/run_main.js:71:12)
    at internal/main/run_main_module.js:17:47 {
  generatedMessage: false,
  code: 'ERR_ASSERTION',
  actual: undefined,
  expected: /A detachable arraybuffer was expected/,
  operator: 'throws'
}

Removing my LGTM until the CI is green.

[targos]

I'm not sure what we are supposed to do. Call ab->Detach() ?

[gengjiawen]

@mmarchini has some suggestion in nodejs/node-v8#149

[mmarchini]

The patch below should fix the failing test, but it would be good to get input from someone more familiar with ArrayBuffers.

diff --git a/test/js-native-api/test_typedarray/test.js b/test/js-native-api/test_typedarray/test.js
index 0d9594d929..f3efcc6e23 100644
--- a/test/js-native-api/test_typedarray/test.js
+++ b/test/js-native-api/test_typedarray/test.js
@@ -78,9 +78,7 @@ nonByteArrayTypes.forEach((currentType) => {
 // Test detaching
 arrayTypes.forEach((currentType) => {
   const buffer = Reflect.construct(currentType, [8]);
-  assert.throws(
-    () => test_typedarray.Detach(buffer),
-    /A detachable arraybuffer was expected/);
+  assert.doesNotThrow(() => test_typedarray.Detach(buffer));
 });
 {
   const buffer = test_typedarray.External();

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/29942/

[targos]

adapted the test to be more meaningful

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/29943/

[targos]

Landed in d23eed2